[5/5] zdtm: now tempfs_overmounted will pass so remove crfail

Submitted by Pavel Tikhomirov on Nov. 24, 2017, 2:22 p.m.

Details

Message ID 20171124142221.31851-6-ptikhomirov@virtuozzo.com
State New
Series "mount: make it possible to dump overmounted mount"
Headers show

Commit Message

Pavel Tikhomirov Nov. 24, 2017, 2:22 p.m.
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
 test/zdtm/static/tempfs_overmounted.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/test/zdtm/static/tempfs_overmounted.desc b/test/zdtm/static/tempfs_overmounted.desc
index 0d8b7f2b4..7657ba45c 100644
--- a/test/zdtm/static/tempfs_overmounted.desc
+++ b/test/zdtm/static/tempfs_overmounted.desc
@@ -1 +1 @@ 
-{'flavor': 'ns uns', 'flags': 'suid crfail'}
+{'flavor': 'ns uns', 'flags': 'suid'}

Comments

Andrei Vagin Dec. 2, 2017, 5:20 a.m.
On Fri, Nov 24, 2017 at 05:22:21PM +0300, Pavel Tikhomirov wrote:
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
>  test/zdtm/static/tempfs_overmounted.desc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/zdtm/static/tempfs_overmounted.desc b/test/zdtm/static/tempfs_overmounted.desc
> index 0d8b7f2b4..7657ba45c 100644
> --- a/test/zdtm/static/tempfs_overmounted.desc
> +++ b/test/zdtm/static/tempfs_overmounted.desc
> @@ -1 +1 @@
> -{'flavor': 'ns uns', 'flags': 'suid crfail'}
> +{'flavor': 'ns uns', 'flags': 'suid'}

You need to improve this test, it checks nothing now.

For example, you can apply the attached patch and try to run it

=== Run 1/1 ================ zdtm/static/tempfs_overmounted

=================== Run zdtm/static/tempfs_overmounted in ns ===================
Start test
Test is SUID
./tempfs_overmounted --pidfile=tempfs_overmounted.pid --outfile=tempfs_overmounted.out --dirname=tempfs_overmounted.test
Run criu dump
Unable to kill 43: [Errno 3] No such process
Run criu restore
1: Old mounts lost: [('/', '/zdtm/static/tempfs_overmounted.test/a')]
1: New mounts appeared: []
4: Old mounts lost: [('/', '/zdtm/static/tempfs_overmounted.test/a')]
4: New mounts appeared: []
Send the 15 signal to  78
Wait for zdtm/static/tempfs_overmounted(78) to die for 0.100000
Unable to kill 78: [Errno 3] No such process
########### Test zdtm/static/tempfs_overmounted FAIL at result check ###########
Test output: ================================
05:19:50.137:     4: ERR: tempfs_overmounted.c:62: umount
 <<< ================================
##################################### FAIL #####################################


> -- 
> 2.13.6
>