[RHEL7,COMMIT] net: drop direct dst_gc_task() call on netdev shutdown

Submitted by Konstantin Khorenko on Dec. 18, 2017, 2:38 p.m.

Details

Message ID 201712181438.vBIEcBR6014015@finist_ce7.work
State New
Series "net: drop direct dst_gc_task() call on netdev shutdown"
Headers show

Commit Message

Konstantin Khorenko Dec. 18, 2017, 2:38 p.m.
The commit is pushed to "branch-rh7-3.10.0-693.11.1.vz7.39.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-693.11.1.vz7.39.7
------>
commit e2305b367f953cfb063c930ae652942dae113af5
Author: Konstantin Khorenko <khorenko@virtuozzo.com>
Date:   Mon Dec 18 17:38:11 2017 +0300

    net: drop direct dst_gc_task() call on netdev shutdown
    
    It was added on a rebase from 2.6.32-x to 3.10.0-x as a part
    of big (cumulative) patch.
    
    i suspect it was added as a part of work of getting rid of
    leaking network devices, but we have not seen that problem
    for a long time already and with this call added
    a Container is stopped slower (waits for dst_gc_task() finish).
    
    Let's drop this call now.
    If we ever get new leaking network devices, we'll see
    appropriate messages and dig the problem.
    
    Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 net/core/dst.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/net/core/dst.c b/net/core/dst.c
index 8f3026cc6eed..95482da244cc 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -435,7 +435,6 @@  static int dst_dev_event(struct notifier_block *this, unsigned long event,
 	switch (event) {
 	case NETDEV_UNREGISTER_FINAL:
 	case NETDEV_DOWN:
-		dst_gc_task(NULL);
 		mutex_lock(&dst_gc_mutex);
 		for (dst = dst_busy_list; dst; dst = dst->next) {
 			last = dst;