[RHEL7,COMMIT] kernel/panic.c: don't dump_stack() in add_taint()

Submitted by Konstantin Khorenko on June 4, 2018, 8:14 p.m.

Details

Message ID 201806042014.w54KEkCI005325@finist_ce7.work
State New
Series "kernel/panic.c: don't dump_stack() in add_taint()"
Headers show

Commit Message

Konstantin Khorenko June 4, 2018, 8:14 p.m.
The commit is pushed to "branch-rh7-3.10.0-693.21.1.vz7.50.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-693.21.1.vz7.50.4
------>
commit 3b2f6f50b6f6ac36a3b41357d1f2905970f17e63
Author: Andrey Ryabinin <aryabinin@virtuozzo.com>
Date:   Mon Jun 4 23:14:45 2018 +0300

    kernel/panic.c: don't dump_stack() in add_taint()
    
    add_taint() callers usually call dump_stack(). The second
    dump_stack() only polutes the log.
    
    This effectively reverts:
    a636e01ad813 ("FIXME: to drop: ve/kernel/taint: Port diff-taint-message-enhanced-with-dump")
    
    Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 kernel/panic.c | 6 ------
 1 file changed, 6 deletions(-)

Patch hide | download patch | download mbox

diff --git a/kernel/panic.c b/kernel/panic.c
index 333e36cd1175..6d33011078d2 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -387,12 +387,6 @@  void add_taint(unsigned flag, enum lockdep_ok lockdep_ok)
 		printk(KERN_WARNING
 		       "Disabling lock debugging due to kernel taint\n");
 
-	/* Do not confuse people with calltraces on proprietary modules */
-	if (flag != TAINT_PROPRIETARY_MODULE && flag != TAINT_OOT_MODULE &&
-	    flag != TAINT_UNSIGNED_MODULE) {
-		printk(KERN_WARNING "Tainting kernel with flag 0x%x\n", flag);
-		dump_stack();
-	}
 	set_bit(flag, &tainted_mask);
 }
 EXPORT_SYMBOL(add_taint);