delete a redundant if

Submitted by Fangrui Song on March 13, 2019, 10:12 a.m.

Details

Message ID MWHPR22MB167999DFCFD4FF85A04CD344CB4A0@MWHPR22MB1679.namprd22.prod.outlook.com
State New
Series "delete a redundant if"
Headers show

Commit Message

Fangrui Song March 13, 2019, 10:12 a.m.

Patch hide | download patch | download mbox

---
 ldso/dynlink.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index 46c5b5ff..206427fe 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -1461,7 +1461,6 @@  static void do_init_fini(struct dso **queue)
 			pthread_cond_wait(&ctor_cond, &init_fini_lock);
 		if (p->ctor_visitor || p->constructed)
 			continue;
-		if (p->constructed) continue;
 		p->ctor_visitor = self;
 		
 		decode_vec(p->dynv, dyn, DYN_CNT);
-- 
2.20.1


Comments

Rich Felker April 2, 2019, 2:38 p.m.
On Wed, Mar 13, 2019 at 10:12:17AM +0000, Ray wrote:
> 

> ---
>  ldso/dynlink.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ldso/dynlink.c b/ldso/dynlink.c
> index 46c5b5ff..206427fe 100644
> --- a/ldso/dynlink.c
> +++ b/ldso/dynlink.c
> @@ -1461,7 +1461,6 @@ static void do_init_fini(struct dso **queue)
>  			pthread_cond_wait(&ctor_cond, &init_fini_lock);
>  		if (p->ctor_visitor || p->constructed)
>  			continue;
> -		if (p->constructed) continue;
>  		p->ctor_visitor = self;
>  		
>  		decode_vec(p->dynv, dyn, DYN_CNT);
> -- 
> 2.20.1
> 

Sorry I overlooked this when you posted it. Applying. Thanks!

Rich