(no subject)

Submitted by Konstantin Khorenko on April 3, 2019, 11:25 a.m.

Details

Message ID 201904031125.x33BPRxq007537@finist-ce7.sw.ru
State New
Series "(no subject)"
Headers show

Commit Message

Konstantin Khorenko April 3, 2019, 11:25 a.m.
<20181011184646.154065-1-pshier@google.com>
Subject: [PATCH RHEL7 COMMIT] ms/KVM: nVMX: unconditionally cancel preemption timer in free_nested (CVE-2019-7221)

The commit is pushed to "branch-rh7-3.10.0-957.10.1.vz7.85.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-957.10.1.vz7.85.11
------>
commit c88cf27ca413588185cf6059aec9579ef5ef6730
Author: Peter Shier <pshier@google.com>
Date:   Wed Apr 3 14:25:27 2019 +0300

    ms/KVM: nVMX: unconditionally cancel preemption timer in free_nested (CVE-2019-7221)
    
    Bugzilla: 1671904
    
    There are multiple code paths where an hrtimer may have been started to
    emulate an L1 VMX preemption timer that can result in a call to free_nested
    without an intervening L2 exit where the hrtimer is normally
    cancelled. Unconditionally cancel in free_nested to cover all cases.
    
    Embargoed until Feb 7th 2019.
    
    Signed-off-by: Peter Shier <pshier@google.com>
    Reported-by: Jim Mattson <jmattson@google.com>
    Reviewed-by: Jim Mattson <jmattson@google.com>
    Reported-by: Felix Wilhelm <fwilhelm@google.com>
    Cc: stable@kernel.org
    Message-Id: <20181011184646.154065-1-pshier@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    
    Commit ecec76885bcfe3294685dc363fd1273df0d5d65f in the mainline kernel.
    In vzkernel vz7.85.x, the code of interest is in arch/x86/kvm/vmx.c,
    while the mainline has it in arch/x86/kvm/vmx/nested.c.
    
    https://jira.sw.ru/browse/PSBM-93359
    
    Signed-off-by: Evgenii Shatokhin <eshatokhin@virtuozzo.com>
---
 arch/x86/kvm/vmx.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 197151e8832f..0fe9feefbe39 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -7330,6 +7330,7 @@  static void free_nested(struct vcpu_vmx *vmx)
 	if (!vmx->nested.vmxon && !vmx->nested.smm.vmxon)
 		return;
 
+	hrtimer_cancel(&vmx->nested.preemption_timer);
 	vmx->nested.vmxon = false;
 	vmx->nested.smm.vmxon = false;
 	free_vpid(vmx->nested.vpid02);