| Message ID | 155714469872.21039.17298483908748255597.stgit@localhost.localdomain |
|---|---|
| State | New |
| Series | "ploop: Check for top_delta in ploop_congested()" |
| Headers | show
Delivered-To: criupatchwork@gmail.com Received: from gmail-imap.l.google.com [74.125.131.108] by patchwork.criu.org with IMAP (fetchmail-6.3.26) for <root@localhost> (single-drop); Mon, 06 May 2019 14:14:01 +0200 (CEST) Received: by 2002:a6b:251:0:0:0:0:0 with SMTP id 78csp2436870ioc; Mon, 6 May 2019 05:13:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5UxSCdw2K8DztkrJjnSB42pbv+wZgYRPxf8VDAWnwTv4UkmrM2xW6LMU+elnOdttrUrzZ X-Received: by 2002:a63:1852:: with SMTP id 18mr31494446pgy.283.1557144834612; Mon, 06 May 2019 05:13:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557144834; cv=none; d=google.com; s=arc-20160816; b=0MQnV18AiZjGw5FfQfiM49vGmhrc1tCYDeHmai0UZT4JzsTJIYFyG/2eDqCmrwGXWq h6e6H7V0W/6JEjXWab18PZ6HTVId8IXScr66Tq0b8xfCMmZffUVRXU+HfynKsI9ELew+ m1N2KqE6jdeZ0MAP3BkTjP2ZGbOJvDLUK5aiB77QnONv3nMpg2dvu81H+Ss/mkh4YVXp U8pjuvVhqRXoan9hF8aCDSvMYA2DpprvQleSHBtp92+zlxqZm2Gt0R6IeXUTibivsOdG y5+gwvlP9hybps+WMHnasbZeobtIcow1o3cUDgY3FySFl58yaYE+tbYBAdpojbxxT5+j G97g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:user-agent:message-id:date:to:from; bh=mJTaYZgTaW6jF82g2r9H9C5qbC9jplm0B3bJtJgnuMI=; b=TtXCEWbNUIstUOHUjli7NglgUc75/al8JVRRffec9aogp0DV3nIPKOskLfH4oPV13K AN0ulkwmEm3qz2mXu5tarTUwzkFWIHTijEWgZrvqcQnCi2momHB5dRjrA022ZyUUM+j6 wn0ag4j+KokO4Oh6BBhrqQDRmbwUY3/1KS0QK+j3c4jzOLzUCBjpYQ79hi9q2DEifxDH uXBVjePLQIX7Vz4MvP00HE/6jFxmWtjGpD4DtEnCo7jklLFKIFuOSGVofBTS9Zz3sG8G XdqbTsJu4hscAThzhZxZMDIAVto1lVq8oc3Mvd69A7pRTPo2STU1OAVEksTzgTDJWbfT 8IlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: <devel-bounces@openvz.org> Received: from mail.openvz.org (mail.openvz.org. [185.231.241.50]) by mx.google.com with ESMTPS id x32si15448936pld.16.2019.05.06.05.13.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 05:13:54 -0700 (PDT) Received-SPF: pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) client-ip=185.231.241.50; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: from localhost.localdomain (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id x46CBlm7008890; Mon, 6 May 2019 15:11:47 +0300 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id x46CBi2A008887 for <devel@openvz.org>; Mon, 6 May 2019 15:11:44 +0300 Received: from VI1PR08CA0160.eurprd08.prod.outlook.com (2603:10a6:800:d1::14) by AM5PR0801MB2050.eurprd08.prod.outlook.com (2603:10a6:203:49::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Mon, 6 May 2019 12:11:45 +0000 Received: from VE1EUR01FT047.eop-EUR01.prod.protection.outlook.com (2a01:111:f400:7e01::204) by VI1PR08CA0160.outlook.office365.com (2603:10a6:800:d1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10 via Frontend Transport; Mon, 6 May 2019 12:11:44 +0000 Authentication-Results: spf=pass (sender IP is 185.231.240.75) smtp.mailfrom=virtuozzo.com; openvz.org; dkim=none (message not signed) header.d=none; openvz.org; dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 185.231.240.75 as permitted sender) receiver=protection.outlook.com; client-ip=185.231.240.75; helo=relay.sw.ru; Received: from relay.sw.ru (185.231.240.75) by VE1EUR01FT047.mail.protection.outlook.com (10.152.3.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11 via Frontend Transport; Mon, 6 May 2019 12:11:44 +0000 Received: from [172.16.25.169] (helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from <ktkhai@virtuozzo.com>) id 1hNcT9-0003Kl-KC; Mon, 06 May 2019 15:11:43 +0300 From: Kirill Tkhai <ktkhai@virtuozzo.com> To: <devel@openvz.org>, <khorenko@virtuozzo.com>, <ktkhai@virtuozzo.com> Date: Mon, 6 May 2019 15:11:42 +0300 Message-ID: <155714469872.21039.17298483908748255597.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: SFV:SKI; SFV:SKN; SFS:; DIR:INB; SFP:; SCL:-1; SRVR:AM5PR0801MB2050; H:relay.sw.ru; FPR:; SPF:None; LANG:en; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b5361e8-e742-4ad4-05fe-08d6d21c0192 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4709054)(2017052603328); SRVR:AM5PR0801MB2050; X-MS-TrafficTypeDiagnostic: AM5PR0801MB2050: X-MS-Exchange-PUrlCount: 1 X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a21Ha3BqNy9Eb0UxdXNwS0xKZjlrY0FJUWpWSFJVQmRQQlljR3k2Ym5tQS90?= =?utf-8?B?bTJZdS9uM3BTRTVPcTg0RnlPMVB2ZUdOOFllM0NVRm14S0VHVDl1SmNGcWR6?= =?utf-8?B?a0VPek1PVFRIbzNmVmhKbCtCZGowMzhJZnl5MmRtUnhYLzVzZWhJYWZHb0tE?= =?utf-8?B?ZCtRWXUwMng3bHVKK1RUS3E0L2l4WWd6K2pyQWhRdGtNSnB4dkZCTk9lU2pq?= =?utf-8?B?VUtCUjI1WUpGUVFPR0xLVUdKYjU4K2R3SFdXdEJTenhDN1FLYkxhNUc4ZERN?= =?utf-8?B?NnVJV25pbm5BUm1rWmoyOHBNUUJ3R1pKUXQzZFVaeWhWK3hrdTFBYSt6K3BB?= =?utf-8?B?NUhtVUpGdER3QkNNaWFIZ0dsaTJOSjJXYUhoZCtOU1FVS0Jhd2svMXRRejdj?= =?utf-8?B?Si9xb2JFUjVJclZvZnJnelBqZVZORkxRNnB1ZDg0YldTaVlGbUZoU0NXK3ZE?= =?utf-8?B?NHU1b0NkdWRqMlcycTdJeTl5RFRnVk12Z1pxaXd4c3BVQmpSNzVyZHFHOU9w?= =?utf-8?B?RUN0K0VzbDYyT3JVb1RxNWdMSnZNMXlybnptYkhJNElOSFZvRXI2eWh6bVFq?= =?utf-8?B?MWI4Zy8zZU4xWEIwNWljR2svdWMyQXZRWHFYOE5GWTEzZk5wOHBsc25GRzhT?= =?utf-8?B?RVQzNHlFNHEzZmdVSFpWeGVIbEtzSFphcU9nYWZISHV2c0IyNk95cWVKd09h?= =?utf-8?B?MXhpUWdDSWkzZjJ0WnUrdTAvTUpSQXJVVDl1bjltaWdaNHBuRGJvc0FkOXNF?= =?utf-8?B?MUFmTHJYam1KUklaRVlsc2tRK3dVK3J4V1gyVHhxZDhOME1nRVBMRW9kMks3?= =?utf-8?B?VUVXRXBWYWwxM2E3a3dnK3NIenJVQUU3aExOTXNKVzl2QlBER0hHQ3hXMGNq?= =?utf-8?B?S2NqckZEQ0Z5cnZaQ3lPTnJMZSsyVituem9semFCK2h2ZzNwd0JzTUZVMXEw?= =?utf-8?B?eE5ZelNYcW9FU041Q1MrT2lEdGNHL1VxUEpTZlBDVzNuM1NIbUU4bFc2L1A2?= =?utf-8?B?SjBkUEEzNlhWaDZhaURQZ1kzNzAvNXJvWmNIaERpTk4zcU91ekpBVXBXV2U4?= =?utf-8?B?aEU3a3FCcElRaGw4YlA3R1k5N3NiMVhzZm5uaGx4cWo1Y3hLeHd4U05jRGo5?= =?utf-8?B?ZjdTeWpKYTQ1MzNPR0xWOGdUL2xqRFppRTZWTFA1U1NNK1FnbzcxSUNlZmdR?= =?utf-8?B?YjFSVkppbkI3ZE1KcWNEQ3orMzUzdU5JTmdmdnk4bWlyblVIS2o0MkEvazBT?= =?utf-8?B?b2dBVTVpeHhUUGUrUURCcTNxeWFZRm5WL25FQ3BUczRrYTNucW04bGhGUm1t?= =?utf-8?B?TDN5TzNoOE9tZnVaT2QyM0xIL3FiSEwrY1VxUlkyclVkNnI4UGJNUXhpQnpw?= =?utf-8?Q?gIUcB6XqoDhiGI64Av2OzAWd7sDaaEM8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2019 12:11:44.6497 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b5361e8-e742-4ad4-05fe-08d6d21c0192 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f; Ip=[185.231.240.75]; Helo=[relay.sw.ru] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2050 X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 185.231.240.75 X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-AuthSource: VE1EUR01FT047.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Anonymous X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-TransportTrafficSubType: X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:SKN; SKIP:0; X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: AM5PR0801MB2050.eurprd08.prod.outlook.com Subject: [Devel] [PATCH] ploop: Check for top_delta in ploop_congested() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development <devel.openvz.org> List-Unsubscribe: <https://lists.openvz.org/mailman/options/devel>, <mailto:devel-request@openvz.org?subject=unsubscribe> List-Archive: <http://lists.openvz.org/pipermail/devel/> List-Post: <mailto:devel@openvz.org> List-Help: <mailto:devel-request@openvz.org?subject=help> List-Subscribe: <https://lists.openvz.org/mailman/listinfo/devel>, <mailto:devel-request@openvz.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org |
diff --git a/drivers/block/ploop/dev.c b/drivers/block/ploop/dev.c index 18ffb1092ff8..eb60d37cd9df 100644 --- a/drivers/block/ploop/dev.c +++ b/drivers/block/ploop/dev.c @@ -1116,7 +1116,7 @@ static int ploop_congested(void *data, int bits) int ret = 0; top_delta = ploop_top_delta(plo); - if (top_delta->io.ops->congested) + if (top_delta && top_delta->io.ops->congested) ret |= top_delta->io.ops->congested(&top_delta->io, bits); return ret;
Sometimes we may meet empty delta list in ploop_congested(): BUG: unable to handle kernel NULL pointer dereference at 0000000000000148 IP: [<ffffffffc009f05c>] ploop_congested+0x1c/0x40 [ploop] PGD 8000005e75efd067 PUD 5709a95067 PMD 0 Oops: 0000 [#1] SMP Workqueue: cgroup_destroy cgroup_offline_fn task: ffffa137e0303420 ti: ffffa134b9324000 task.ti: ffffa134b9324000 RIP: 0010:[<ffffffffc009f05c>] [<ffffffffc009f05c>] ploop_congested+0x1c/0x40 [ploop] RSP: 0018:ffffa134b9327890 EFLAGS: 00010246 RAX: ffffa12db23249e0 RBX: ffffa134b9327d20 RCX: 0000000000000000 RDX: ffffa12db23249e0 RSI: 0000000000000002 RDI: 0000000000000000 RBP: ffffa134b9327990 R08: ffffa1094cd513c8 R09: 0000000000000001 R10: 000000007fffffff R11: 0000000000000230 R12: ffffdad02aa2b860 R13: ffffa134b9327a38 R14: ffffdad02aa2b840 R15: 0000000000000001 FS: 0000000000000000(0000) GS:ffffa13b7bfc0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000148 CR3: 0000004b780e4000 CR4: 00000000007607e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 00000000 Call Trace: [<ffffffff9e9be2fd>] ? shrink_page_list+0x22d/0xaa0 [<ffffffff9e9bf153>] shrink_inactive_list+0x1b3/0x6f0 [<ffffffff9e9bf9e8>] ? shrink_active_list+0x358/0x470 [<ffffffff9e9bfea1>] shrink_lruvec+0x3a1/0x720 [<ffffffff9e9bc505>] ? do_shrink_slab+0x45/0x270 [<ffffffff9e9c0392>] shrink_zone+0x172/0x440 [<ffffffff9e9c0a48>] do_try_to_free_pages+0x1a8/0x630 [<ffffffff9ef48ae7>] ? __schedule+0x3f7/0x8d0 [<ffffffff9e9c111e>] try_to_free_mem_cgroup_pages+0xee/0x1b0 [<ffffffff9ea2c093>] mem_cgroup_css_offline+0xd3/0x2a0 [<ffffffff9e92cf42>] cgroup_offline_fn+0x92/0x190 [<ffffffff9e8b7622>] process_one_work+0x182/0x440 [<ffffffff9e8b87d6>] worker_thread+0x126/0x3c0 [<ffffffff9e8b86b0>] ? manage_workers.isra.24+0x2a0/0x2a0 [<ffffffff9e8bf741>] kthread+0xd1/0xe0 Currently we don't know the actual way we came into this situation, because crash dump is incomplete (and I don't see the way in code). But it's possible, since we crashed, so let's fix the problem. https://jira.sw.ru/browse/PSBM-94270 Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> --- drivers/block/ploop/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)