[01/10] build/pie: Add comments to build files

Submitted by Dmitry Safonov on May 17, 2019, 10:53 p.m.

Details

Message ID 20190517225309.16082-2-dima@arista.com
State Accepted
Series "pie/build: Cleaning up PIE/compel"
Commit 2e7c03360153ac035cdc7c3bd0eae8bdbf953f7a
Headers show

Commit Message

Dmitry Safonov May 17, 2019, 10:53 p.m.
And drop a stale comment that doesn't clearify anything.

Signed-off-by: Dmitry Safonov <dima@arista.com>
---
 criu/pie/Makefile         |  4 ++++
 criu/pie/Makefile.library | 12 ++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

Patch hide | download patch | download mbox

diff --git a/criu/pie/Makefile b/criu/pie/Makefile
index 24f97ea0d35a..739191308e70 100644
--- a/criu/pie/Makefile
+++ b/criu/pie/Makefile
@@ -1,3 +1,7 @@ 
+# Recipes to compile PIEs: parastie and restorer
+# Compel will deal with converting the result binaries
+# to a C array to be used in CRIU.
+
 target		:= parasite restorer
 
 CFLAGS		:= $(filter-out -pg $(CFLAGS-GCOV) $(CFLAGS-ASAN),$(CFLAGS))
diff --git a/criu/pie/Makefile.library b/criu/pie/Makefile.library
index f268b5ded8c7..a48a0ea4c98e 100644
--- a/criu/pie/Makefile.library
+++ b/criu/pie/Makefile.library
@@ -1,3 +1,9 @@ 
+# PIE library is a static library that's going to be linked into
+# *both* CRIU binary and PIEs (parasite/restorer).
+# Please, make sure that you're including here only objects
+# those will be used in CRIU too. For objects files only for PIEs
+# edit their separate recipes criu/pie/Makefile
+
 lib-name		:= pie.lib.a
 
 CFLAGS			+= -fno-stack-protector -DCR_NOGLIBC -fpie
@@ -27,12 +33,6 @@  ifeq ($(SRCARCH),x86)
         CFLAGS_util-vdso-elf32.o	+= -DCONFIG_VDSO_32
 endif
 
-#
-# We can't provide proper mount implementation
-# in parasite code -- it requires run-time rellocation
-# applications, which is not the target of the
-# project.
-#
 CFLAGS		:= $(filter-out -pg $(CFLAGS-GCOV) $(CFLAGS-ASAN),$(CFLAGS))
 
 asflags-y		:= -D__ASSEMBLY__