Asterisk 16 segmentation fault

Submitted by Sebastian Kemper on May 27, 2019, 8:14 p.m.

Details

Message ID 20190527201442.GA2550@darth.lan
State New
Series "Asterisk 16 segmentation fault"
Headers show

Commit Message

Sebastian Kemper May 27, 2019, 8:14 p.m.
On Sat, Mar 02, 2019 at 06:59:48PM +0100, Sebastian Kemper wrote:
> On Sat, Mar 02, 2019 at 12:36:09PM -0500, Rich Felker wrote:
> > Please be aware: This is just fixing the crash, but isn't fixing the
> > logic error in the Asterisk software that led to it. I'm pretty sure
> > module loading is not working correctly. Actually fixing this is going
> > to be a much bigger task.
>
> Hi Rich,
>
> Thanks, I mentioned that.
>
> https://issues.asterisk.org/jira/browse/ASTERISK-28319
>
> Kind regards,
> Seb

Hi all,

All is well that ends well. With help from Corey from Asterisk upstream we
added some code to support permanent dlopen, which can be activated via
"configure --enable-permanent-dlopen".

https://gerrit.asterisk.org/c/asterisk/+/11217

The code has been queued for Asterisk 16.4.0 and is already in OpenWrt
trunk.

The other problem we had (regarding the redefinitions in astmm.h) we fixed with
a small patch that was suggested by Timo from Alpine Linux.


Thanks again for your support!

Kind regards,
Seb

Patch hide | download patch | download mbox

--- a/include/asterisk/compat.h
+++ b/include/asterisk/compat.h
@@ -30,6 +30,7 @@ 
 #include <inttypes.h>
 #include <limits.h>
 #include <unistd.h>
+#include <pthread.h>

 #ifdef HAVE_STDDEF_H
 #include <stddef.h>

Comments

Rich Felker May 28, 2019, 8:21 p.m.
On Mon, May 27, 2019 at 10:14:42PM +0200, Sebastian Kemper wrote:
> On Sat, Mar 02, 2019 at 06:59:48PM +0100, Sebastian Kemper wrote:
> > On Sat, Mar 02, 2019 at 12:36:09PM -0500, Rich Felker wrote:
> > > Please be aware: This is just fixing the crash, but isn't fixing the
> > > logic error in the Asterisk software that led to it. I'm pretty sure
> > > module loading is not working correctly. Actually fixing this is going
> > > to be a much bigger task.
> >
> > Hi Rich,
> >
> > Thanks, I mentioned that.
> >
> > https://issues.asterisk.org/jira/browse/ASTERISK-28319
> >
> > Kind regards,
> > Seb
> 
> Hi all,
> 
> All is well that ends well. With help from Corey from Asterisk upstream we
> added some code to support permanent dlopen, which can be activated via
> "configure --enable-permanent-dlopen".
> 
> https://gerrit.asterisk.org/c/asterisk/+/11217
> 
> The code has been queued for Asterisk 16.4.0 and is already in OpenWrt
> trunk.
> 
> The other problem we had (regarding the redefinitions in astmm.h) we fixed with
> a small patch that was suggested by Timo from Alpine Linux.
> 
> --- a/include/asterisk/compat.h
> +++ b/include/asterisk/compat.h
> @@ -30,6 +30,7 @@
>  #include <inttypes.h>
>  #include <limits.h>
>  #include <unistd.h>
> +#include <pthread.h>
> 
>  #ifdef HAVE_STDDEF_H
>  #include <stddef.h>
> 
> Thanks again for your support!

Thanks for the update! It's nice to know this should be working
correctly now without hacks or silent breakage.

Rich