[RHEL7,COMMIT] Revert "mm/memcontrol: warn about leaking memory on reparenting"

Submitted by Konstantin Khorenko on July 8, 2019, 9:01 a.m.

Details

Message ID 201907080901.x6891AFO019507@finist-ce7.sw.ru
State New
Series "mm/memcontrol: don't reparent forever if counter leaked."
Headers show

Commit Message

Konstantin Khorenko July 8, 2019, 9:01 a.m.
The commit is pushed to "branch-rh7-3.10.0-957.21.3.vz7.106.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-957.21.3.vz7.106.5
------>
commit ddb5c5f7f3bbca4589d0e74901135bb445733c72
Author: Konstantin Khorenko <khorenko@virtuozzo.com>
Date:   Mon Jul 8 11:59:09 2019 +0300

    Revert "mm/memcontrol: warn about leaking memory on reparenting"
    
    This reverts commit fb2d3af5b3f4e122c06592549684f3b3d884cc8f.
    
    OK, now we know for sure that 1 iteration is not enough in some cases,
    let's now findout what exactly prevents successful memory reparenting at
    once - in the next patch.
    
    https://jira.sw.ru/browse/PSBM-96003
    
    Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 mm/memcontrol.c | 8 --------
 1 file changed, 8 deletions(-)

Patch hide | download patch | download mbox

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e123323f1044..edc6bebc1f34 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4325,14 +4325,6 @@  static void mem_cgroup_reparent_charges(struct mem_cgroup *memcg)
 		 */
 	} while ((page_counter_read(&memcg->memory) -
 		 page_counter_read(&memcg->kmem) > 0) && reparent_attempts--);
-
-	WARN_ONCE(reparent_attempts != 10,
-		  "memcg 0x%p leak suspected, performed %d iterations: "
-		  "memory=%lu, kmem=%lu",
-		  memcg,
-		  10 - reparent_attempts,
-		  page_counter_read(&memcg->memory),
-		  page_counter_read(&memcg->kmem));
 }
 
 /*