Message ID | 20191031100834.16101-1-khorenko@virtuozzo.com |
---|---|
State | New |
Series | "sctp: suppress warnings on high order memory allocation on sctp chunk creation" |
Headers | show
Delivered-To: criupatchwork@gmail.com Received: from gmail-imap.l.google.com [74.125.131.108] by patchwork.criu.org with IMAP (fetchmail-6.3.26) for <root@localhost> (single-drop); Thu, 31 Oct 2019 11:10:58 +0100 (CET) Received: by 2002:a6b:6312:0:0:0:0:0 with SMTP id p18csp2520386iog; Thu, 31 Oct 2019 03:10:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcA11fgPvqlK8LWigy76xWAa53FvroRLcZ8IzBGjXC0KXtY0VXW1ACbLoh+DudRfOPAzIo X-Received: by 2002:a2e:8545:: with SMTP id u5mr3624632ljj.213.1572516654710; Thu, 31 Oct 2019 03:10:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572516654; cv=none; d=google.com; s=arc-20160816; b=G+NghP5VR4VrSy89GA+di6yFVXPRC8fvYewgyHqt870D1yx8IR2s+dm+TXd7vpu/xb 8KcUC3p7EHewjPsd5FM6jyS3xq6P7SI7rw7LrKBpc+BBxM9fAfpSaClBAPlaZyBqQiny T8HewnU014VUFdG/IG9rYCZd4oT12tBfai6FNDie4cfegtMzYNmXLFJAvn3QBbG5CgDc iIBgA0gB8CU/7IhDCOdxNbnakMje79vbTMxoX5SDZiDb8xF7Nsa7kE8ak/IoAy8r57En 961m35Ugi0tf/V29wMZPk+lrUVflKV7zjmF8DWpg9yGPDbn308V0Qbh308XgHyNo/WKT HeqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :cc:mime-version:message-id:date:to:from; bh=YH7KTKONumbkMz4Cf1/rTlcEFT47vpwmIThMLz0T1d8=; b=auMUK1s1fdqoOzVBXeiU+FxHxBKLRNULXkMTEO/ucUHReUAtmrtDPzfY7rYPZSsfrK 2hKII6ZiUMkhtBTSKrk7lj4f+OwfF/G+fevuwFbMyDUBVEjLDHgxrN0SA9Ep1gxwM8K1 tD5Jv5EZ+3bxVTB9szKUBJ+Ar6QNTvAjJk3q/4tD9mrUPOZ08l1+AUDOhqkLtrPsALIP ihVJ0jGw7tZmfqg6/CcVZMQBUumTrnjyLd1Dz0aGqLuSuOQWSSTPp8MU4AcdINSNhupH bimj+0q38ldG3ITwGInJ0hbGErdDFRpUVSak078M/EhSPJskVDPm9sU5G7vgFamAJc+e 62rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: <devel-bounces@openvz.org> Received: from mail.openvz.org (mail.openvz.org. [185.231.241.50]) by mx.google.com with ESMTPS id d3si5712763ljg.168.2019.10.31.03.10.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2019 03:10:54 -0700 (PDT) Received-SPF: pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) client-ip=185.231.241.50; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 185.231.241.50 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: from localhost.localdomain (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id x9VA8d1u003112; Thu, 31 Oct 2019 13:08:50 +0300 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id x9VA8Y1t003109 for <devel@openvz.org>; Thu, 31 Oct 2019 13:08:34 +0300 Received: from AM6PR08CA0016.eurprd08.prod.outlook.com (2603:10a6:20b:b2::28) by DB6PR0802MB2357.eurprd08.prod.outlook.com (2603:10a6:4:87::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Thu, 31 Oct 2019 10:08:36 +0000 Received: from VE1EUR01FT009.eop-EUR01.prod.protection.outlook.com (2a01:111:f400:7e01::202) by AM6PR08CA0016.outlook.office365.com (2603:10a6:20b:b2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.19 via Frontend Transport; Thu, 31 Oct 2019 10:08:36 +0000 Authentication-Results: spf=pass (sender IP is 185.231.240.75) smtp.mailfrom=virtuozzo.com; openvz.org; dkim=none (message not signed) header.d=none; openvz.org; dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 185.231.240.75 as permitted sender) receiver=protection.outlook.com; client-ip=185.231.240.75; helo=relay.sw.ru; Received: from relay.sw.ru (185.231.240.75) by VE1EUR01FT009.mail.protection.outlook.com (10.152.2.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20 via Frontend Transport; Thu, 31 Oct 2019 10:08:35 +0000 Received: from [10.94.4.83] (helo=finist-ce7.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from <khorenko@virtuozzo.com>) id 1iQ7Nb-0003rL-4S; Thu, 31 Oct 2019 13:08:35 +0300 From: Konstantin Khorenko <khorenko@virtuozzo.com> To: Andrey Ryabinin <aryabinin@virtuozzo.com> Date: Thu, 31 Oct 2019 13:08:34 +0300 Message-Id: <20191031100834.16101-1-khorenko@virtuozzo.com> X-Mailer: git-send-email 2.15.1 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: SFV:SKI; SFV:SKN; SFS:; DIR:INB; SFP:; SCL:-1; SRVR:DB6PR0802MB2357; H:relay.sw.ru; FPR:; SPF:None; LANG:en; MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4673ee55-7571-4b94-abbe-08d75dea4b0b X-MS-TrafficTypeDiagnostic: DB6PR0802MB2357: X-MS-Exchange-PUrlCount: 1 X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?D4CEyeQrTkXuzP4VcKqgU290/B7L+u4aeZYvL2EIoI4swNrZHOB20aoQPVpG?= =?us-ascii?Q?76UXzed1Mb/3V03eRHow7V+dzp1J2EsLX7dcQqqR8wlWwkvoIngP3QEE1UuP?= =?us-ascii?Q?sgb7hiePJUlG7ME0p/qxgRD5SKO41jrNna8O5I1eJOk8ezi6hixjRNlwtNK5?= =?us-ascii?Q?aGTL0vU6qfL4xvlzWiqyO6ssIw8iSdTjz5A2VRwCQlWdKtq4NhnFJNTfayoZ?= =?us-ascii?Q?xobPHVPhaz/eN2TjIzD8+3foIpf7cVRHsh9tFNSsJbzjY0ZjzgCXEJ+VPn7Q?= =?us-ascii?Q?/iBVWB9fpqOa82LXUflRuSVhRIfrMe/HH+E/glVRJciqROuvrwfTOyo4MlXQ?= =?us-ascii?Q?9OYkRPBbkze+BU4CJrTM6nDyZ1exv9ptFzuH3hSKn9msCQiiqgN7ny5rf+40?= =?us-ascii?Q?kBydok+6xvaBd880G9elDzhhl1he6YwqQitJ332sozm20Ffzix6rX8b2t7+I?= =?us-ascii?Q?OEgUaaCOY1oO8z4DelMdWAURPFXpqX4ABfzIha/sDRKTucPLwgtx63mUelpT?= =?us-ascii?Q?W/Ic6i8qlRVi+pdTu7T9ry9ddplfdH4n6oHGg1bx5X723yikcvCDV+1sjE7q?= =?us-ascii?Q?mwZURU8JLtEDy5cE3vVxF6IBrGQ5dsMNC/3BascVX8KmiqK1hYXjZCUHAf3C?= =?us-ascii?Q?+FZvxvyF6RIkgRsXsnuYZUkT7GqGw+vI6zYvWtjmKIFsOAOEXWg6Gq4wjvZG?= =?us-ascii?Q?sHgSdjgQ90fY5fkw6wCFXjAtYrgBEFIQVfaCKdjVCVMjxbr7qNgWpgmXa8lu?= =?us-ascii?Q?qUyScKnVQU53GYH2drq/w92PfQZWB8Ix74+5SGXjPJkspVE3+taszjOx1FcY?= =?us-ascii?Q?3dMdJ9Ht7S4ZFNyTDFaMcatBYebhdFsnos2hmiaU4y9GqoAueFt0nALJlw9Q?= =?us-ascii?Q?SQHX3LB0NbdDZ5OUxnvTsZrDOFyjKwmu0A4iDcQG3G5qUbJwvAFWRWAKXrmZ?= =?us-ascii?Q?JIt0EqinTIvFKbjIDS9WHmVE67m5XOylnWJPAmVRsXVZzrqHnmo3AMyzOPFN?= =?us-ascii?Q?HNus5FwA6aj7sXep9FFCsKzLwQUhIkMXZSosxVkV6BDEX9/NmS96HzVVJVHy?= =?us-ascii?Q?SLaDgLgMn5o0FABDFRI2sayENnmBM9UXQ5Mfy4Z5DzABOH3wxmabQt88l3uq?= =?us-ascii?Q?P8QXd9OBKaSfkczxYeZ+Q8EnVBRtOTShDA=3D=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2019 10:08:35.8970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4673ee55-7571-4b94-abbe-08d75dea4b0b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f; Ip=[185.231.240.75]; Helo=[relay.sw.ru] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2357 X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 185.231.240.75 X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-AuthSource: VE1EUR01FT009.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Anonymous X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-TransportTrafficSubType: X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:SKN; SKIP:0; X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: DB6PR0802MB2357.eurprd08.prod.outlook.com Cc: den@virtuozzo.com, OpenVZ devel list <devel@openvz.org> Subject: [Devel] [PATCH rh7] sctp: suppress warnings on high order memory allocation on sctp chunk creation X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development <devel.openvz.org> List-Unsubscribe: <https://lists.openvz.org/mailman/options/devel>, <mailto:devel-request@openvz.org?subject=unsubscribe> List-Archive: <http://lists.openvz.org/pipermail/devel/> List-Post: <mailto:devel@openvz.org> List-Help: <mailto:devel-request@openvz.org?subject=help> List-Subscribe: <https://lists.openvz.org/mailman/listinfo/devel>, <mailto:devel-request@openvz.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org |
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 8fef389dd2fa..4611e85ace9f 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c @@ -1408,7 +1408,7 @@ static struct sctp_chunk *_sctp_make_chunk(const struct sctp_association *asoc, goto nodata; /* No need to allocate LL here, as this is only a chunk. */ - skb = alloc_skb(chunklen, gfp); + skb = alloc_skb(chunklen, gfp | __GFP_ORDER_NOWARN); if (!skb) goto nodata;
_sctp_make_chunk() could allocate skbs up to 65K in size (4th order page), so we get complains about high order page allocations from our detection mechanizm while running sctp testsuite. It's not evident that substituting alloc_skb() with alloc_skb_with_frags() speeds up the sender performance. On another hand if the node's memory is highly fragmented and allocation of high order pages has noticable latency, it influences the sender most, not the node as a whole. And taking into account that sctp is not widely used, let's just shut up the warning in this place. https://jira.sw.ru/browse/PSBM-93798 Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com> --- net/sctp/sm_make_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)