[rh7,1/2] nbd: move nbd_size_update() of of the loop.

Submitted by Andrey Ryabinin on Nov. 5, 2019, 10:39 a.m.

Details

Message ID 20191105103957.5100-1-aryabinin@virtuozzo.com
State New
Series "Series without cover letter"
Headers show

Commit Message

Andrey Ryabinin Nov. 5, 2019, 10:39 a.m. 
nbd_size_update() should be called only once, not once per-connection.
Move it out of the loop.

Fixes: 584f48d40cbc ("nbd: don't set the device size until we're connected")
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 drivers/block/nbd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 79de456643cf..362fe546cb2c 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -974,11 +974,10 @@  static int nbd_start_device(struct nbd_device *nbd, struct block_device *bdev)
 		args->nbd = nbd;
 		args->index = i;
 		queue_work(recv_workqueue, &args->work);
-		nbd_size_update(nbd);
 		if (max_part)
 			bdev->bd_invalidated = 1;
-
 	}
+	nbd_size_update(nbd);
 	error = wait_event_interruptible(config->recv_wq,
 					 atomic_read(&config->recv_threads) == 0);
 	if (error)