[RHEL7,COMMIT] ixgbe: don't check firmware errors

Submitted by Konstantin Khorenko on Jan. 10, 2020, 4:10 p.m.

Details

Message ID 202001101610.00AGA9R2027915@finist-ce7.sw.ru
State New
Series "Series without cover letter"
Headers show

Commit Message

Konstantin Khorenko Jan. 10, 2020, 4:10 p.m.
The commit is pushed to "branch-rh7-3.10.0-1062.7.1.vz7.130.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1062.7.1.vz7.130.10
------>
commit 449deeb9d56dda5be95d3f1888d67a3602da84a3
Author: Konstantin Khorenko <khorenko@virtuozzo.com>
Date:   Fri Jan 10 18:23:19 2020 +0300

    ixgbe: don't check firmware errors
    
    There is a check in new ixgbe version driver in RHEL7.7
    which verify the firmware error register value for correctness.
    
    Apparently seems the check is not fully correct itself
    causing kernel to spoil logs (every second).
    
    The driver in RHEL7.6 does not have that check.
    The driver from vendor site does not have that check.
    https://downloadmirror.intel.com/14687/eng/ixgbe-5.6.5.tar.gz
    
    So let's drop the check as well in Virtuozzo kernels.
    
    https://bugs.centos.org/view.php?id=16495
    https://forum.proxmox.com/threads/pve-6-0-7-ixgbe-firmware-errors.58592/
    https://jira.sw.ru/browse/PSBM-100722
    
    Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 ---------
 1 file changed, 9 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index eef479f762f93..b39a1b477b246 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7913,15 +7913,6 @@  static void ixgbe_reset_subtask(struct ixgbe_adapter *adapter)
 static bool ixgbe_check_fw_error(struct ixgbe_adapter *adapter)
 {
 	struct ixgbe_hw *hw = &adapter->hw;
-	u32 fwsm;
-
-	/* read fwsm.ext_err_ind register and log errors */
-	fwsm = IXGBE_READ_REG(hw, IXGBE_FWSM(hw));
-
-	if (fwsm & IXGBE_FWSM_EXT_ERR_IND_MASK ||
-	    !(fwsm & IXGBE_FWSM_FW_VAL_BIT))
-		e_dev_warn("Warning firmware error detected FWSM: 0x%08X\n",
-			   fwsm);
 
 	if (hw->mac.ops.fw_recovery_mode && hw->mac.ops.fw_recovery_mode(hw)) {
 		e_dev_err("Firmware recovery mode detected. Limiting functionality. Refer to the Intel(R) Ethernet Adapters and Devices User Guide for details on firmware recovery mode.\n");