[rh7,3/3] quota: fix potential infinite loop

Submitted by Andrey Ryabinin on Jan. 27, 2020, 5:15 p.m.

Details

Message ID 20200127171536.14185-3-aryabinin@virtuozzo.com
State New
Series "Series without cover letter"
Headers show

Commit Message

Andrey Ryabinin Jan. 27, 2020, 5:15 p.m.
From: "zhangyi (F)" <yi.zhang@huawei.com>

In dquot_writeback_dquots(), we write back dquot from dirty dquots
list. There is a potential infinite loop if ->write_dquot() failure
and forget remove dquot from the list. This patch clear dirty bit
anyway to avoid it.

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>

https://jira.sw.ru/browse/PSBM-101043
(cherry picked from commit dd5f6279732e8885061d7455b9d86fdcfdf7f183)
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 fs/quota/dquot.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 989dce79fa12..d6c710c39a2a 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -633,8 +633,15 @@  int dquot_writeback_dquots(struct super_block *sb, int type)
 			spin_unlock(&dq_list_lock);
 			dqstats_inc(DQST_LOOKUPS);
 			err = sb->dq_op->write_dquot(dquot);
-			if (!ret && err)
-				ret = err;
+			if (err) {
+				/*
+				 * Clear dirty bit anyway to avoid infinite
+				 * loop here.
+				 */
+				clear_dquot_dirty(dquot);
+				if (!ret)
+					ret = err;
+			}
 			dqput(dquot);
 			spin_lock(&dq_list_lock);
 		}