[RHEL7,COMMIT] ms/VFS: use synchronize_rcu_expedited() in namespace_unlock()

Submitted by Konstantin Khorenko on March 4, 2020, 4:12 p.m.

Details

Message ID 202003041612.024GCxOm014072@finist-ce7.sw.ru
State New
Series "ms/VFS: use synchronize_rcu_expedited() in namespace_unlock()"
Headers show

Commit Message

Konstantin Khorenko March 4, 2020, 4:12 p.m.
The commit is pushed to "branch-rh7-3.10.0-1062.12.1.vz7.131.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1062.12.1.vz7.131.6
------>
commit 61c6fb0668736de4d7eb66af40a72ee31be18bd6
Author: NeilBrown <neilb@suse.com>
Date:   Wed Mar 4 19:12:59 2020 +0300

    ms/VFS: use synchronize_rcu_expedited() in namespace_unlock()
    
    The synchronize_rcu() in namespace_unlock() is called every time
    a filesystem is unmounted.  If a great many filesystems are mounted,
    this can cause a noticable slow-down in, for example, system shutdown.
    
    The sequence:
      mkdir -p /tmp/Mtest/{0..5000}
      time for i in /tmp/Mtest/*; do mount -t tmpfs tmpfs $i ; done
      time umount /tmp/Mtest/*
    
    on a 4-cpu VM can report 8 seconds to mount the tmpfs filesystems, and
    100 seconds to unmount them.
    
    Boot the same VM with 1 CPU and it takes 18 seconds to mount the
    tmpfs filesystems, but only 36 to unmount.
    
    If we change the synchronize_rcu() to synchronize_rcu_expedited()
    the umount time on a 4-cpu VM drop to 0.6 seconds
    
    I think this 200-fold speed up is worth the slightly high system
    impact of using synchronize_rcu_expedited().
    
    Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> (from general rcu perspective)
    Signed-off-by: NeilBrown <neilb@suse.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    
    https://jira.sw.ru/browse/PSBM-101530
    (cherry-picked from commit 22cb7405fada5305926d9bbcb476c1cd638d2dab)
    Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/fs/namespace.c b/fs/namespace.c
index d4527f5bd75ae..1890491ac9e8f 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1523,7 +1523,7 @@  static void namespace_unlock(void)
 	if (likely(hlist_empty(&head)))
 		return;
 
-	synchronize_rcu();
+	synchronize_rcu_expedited();
 
 	group_pin_kill(&head);
 }