[1/9] Moved functions from parasite-syscall.c and cr-restore.c

Submitted by prakriti goyal on March 16, 2020, 3:59 p.m.

Details

Message ID 20200316155936.18139-1-prakritigoyal19@gmail.com
State New
Series "Series without cover letter"
Headers show

Commit Message

prakriti goyal March 16, 2020, 3:59 p.m.
From: prakritigoyal19 <prakritigoyal19@gmail.com>

Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions

---
 criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 criu/include/sigaction.h

Patch hide | download patch | download mbox

diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
new file mode 100644
index 00000000..ceafade3
--- /dev/null
+++ b/criu/include/sigaction.h
@@ -0,0 +1,38 @@ 
+#ifndef __CR_SIGACTION_H__
+#define __CR_SIGACTION_H__
+
+
+#include <sys/un.h>
+#include <sys/time.h>
+
+#include <unistd.h>
+#include <inttypes.h>
+
+#include "parasite.h"
+#include "parasite-syscall.h"
+#include "pstree.h"
+#include "sigframe.h" //TaskCoreEntry, SaEntry
+
+#include "image.h"
+#include "img-remote.h"
+#include "images/core.pb-c.h"
+#include "images/sa.pb-c.h"
+#include "infect.h"
+#include "infect-rpc.h"
+#include "parasite.h"
+#include "util-pie.h"
+
+#include <compel/compel.h>
+#include "restore.h"
+#include "restorer.h"
+
+
+
+
+extern rt_sigaction_t sigchld_act;
+
+int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct pstree_item *item);
+
+int prepare_sigactions(CoreEntry *core);
+
+#endif

Comments

Pavel Emelyanov March 17, 2020, 7:22 a.m.
пн, 16 мар. 2020 г. в 19:02, prakriti goyal <prakritigoyal19@gmail.com>:

> From: prakritigoyal19 <prakritigoyal19@gmail.com>
>
> Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions
>
>
This branch contains different set of patches. Why is that so?

-- Pavel


> ---
>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 criu/include/sigaction.h
>
> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
> new file mode 100644
> index 00000000..ceafade3
> --- /dev/null
> +++ b/criu/include/sigaction.h
> @@ -0,0 +1,38 @@
> +#ifndef __CR_SIGACTION_H__
> +#define __CR_SIGACTION_H__
> +
> +
> +#include <sys/un.h>
> +#include <sys/time.h>
> +
> +#include <unistd.h>
> +#include <inttypes.h>
> +
> +#include "parasite.h"
> +#include "parasite-syscall.h"
> +#include "pstree.h"
> +#include "sigframe.h" //TaskCoreEntry, SaEntry
> +
> +#include "image.h"
> +#include "img-remote.h"
> +#include "images/core.pb-c.h"
> +#include "images/sa.pb-c.h"
> +#include "infect.h"
> +#include "infect-rpc.h"
> +#include "parasite.h"
> +#include "util-pie.h"
> +
> +#include <compel/compel.h>
> +#include "restore.h"
> +#include "restorer.h"
> +
> +
> +
> +
> +extern rt_sigaction_t sigchld_act;
> +
> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct
> pstree_item *item);
> +
> +int prepare_sigactions(CoreEntry *core);
> +
> +#endif
> --
> 2.17.1
>
> _______________________________________________
> CRIU mailing list
> CRIU@openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
>
Pavel Emelyanov March 17, 2020, 7:56 a.m.
Don't drop mailing list from responses.

вт, 17 мар. 2020 г. в 10:50, prakriti goyal <prakritigoyal19@gmail.com>:

> I'm sorry I'm not familiar with how git format-patch works and worked with
> it for the first time. This caused a lot of patches to be submitted.
>
> The main patch is the [2/9].
>
>
Please, either push another branch, or send another set of patches (or
both) and make sure
the patches we see on the mailing list and the branch you point to contain
identical patches.

-- Pavel


> On Tue 17 Mar, 2020, 12:52 PM Pavel Emelyanov, <ovzxemul@gmail.com> wrote:
>
>>
>>
>> пн, 16 мар. 2020 г. в 19:02, prakriti goyal <prakritigoyal19@gmail.com>:
>>
>>> From: prakritigoyal19 <prakritigoyal19@gmail.com>
>>>
>>> Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
>>> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions
>>>
>>>
>> This branch contains different set of patches. Why is that so?
>>
>> -- Pavel
>>
>>
>>> ---
>>>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 38 insertions(+)
>>>  create mode 100644 criu/include/sigaction.h
>>>
>>> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
>>> new file mode 100644
>>> index 00000000..ceafade3
>>> --- /dev/null
>>> +++ b/criu/include/sigaction.h
>>> @@ -0,0 +1,38 @@
>>> +#ifndef __CR_SIGACTION_H__
>>> +#define __CR_SIGACTION_H__
>>> +
>>> +
>>> +#include <sys/un.h>
>>> +#include <sys/time.h>
>>> +
>>> +#include <unistd.h>
>>> +#include <inttypes.h>
>>> +
>>> +#include "parasite.h"
>>> +#include "parasite-syscall.h"
>>> +#include "pstree.h"
>>> +#include "sigframe.h" //TaskCoreEntry, SaEntry
>>> +
>>> +#include "image.h"
>>> +#include "img-remote.h"
>>> +#include "images/core.pb-c.h"
>>> +#include "images/sa.pb-c.h"
>>> +#include "infect.h"
>>> +#include "infect-rpc.h"
>>> +#include "parasite.h"
>>> +#include "util-pie.h"
>>> +
>>> +#include <compel/compel.h>
>>> +#include "restore.h"
>>> +#include "restorer.h"
>>> +
>>> +
>>> +
>>> +
>>> +extern rt_sigaction_t sigchld_act;
>>> +
>>> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct
>>> pstree_item *item);
>>> +
>>> +int prepare_sigactions(CoreEntry *core);
>>> +
>>> +#endif
>>> --
>>> 2.17.1
>>>
>>> _______________________________________________
>>> CRIU mailing list
>>> CRIU@openvz.org
>>> https://lists.openvz.org/mailman/listinfo/criu
>>>
>>
Pavel Tikhomirov March 17, 2020, 8:13 a.m.
I think we also need some description why we move this functions in
patch subject and description.

Also please remove extra empty lines and spaces in the end of lines.

Best Regards, Tikhomirov Pavel.

вт, 17 мар. 2020 г. в 11:00, Pavel Emelyanov <ovzxemul@gmail.com>:
>
> Don't drop mailing list from responses.
>
> вт, 17 мар. 2020 г. в 10:50, prakriti goyal <prakritigoyal19@gmail.com>:
>>
>> I'm sorry I'm not familiar with how git format-patch works and worked with it for the first time. This caused a lot of patches to be submitted.
>>
>> The main patch is the [2/9].
>>
>
> Please, either push another branch, or send another set of patches (or both) and make sure
> the patches we see on the mailing list and the branch you point to contain identical patches.
>
> -- Pavel
>
>>
>> On Tue 17 Mar, 2020, 12:52 PM Pavel Emelyanov, <ovzxemul@gmail.com> wrote:
>>>
>>>
>>>
>>> пн, 16 мар. 2020 г. в 19:02, prakriti goyal <prakritigoyal19@gmail.com>:
>>>>
>>>> From: prakritigoyal19 <prakritigoyal19@gmail.com>
>>>>
>>>> Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
>>>> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions
>>>>
>>>
>>> This branch contains different set of patches. Why is that so?
>>>
>>> -- Pavel
>>>
>>>>
>>>> ---
>>>>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
>>>>  1 file changed, 38 insertions(+)
>>>>  create mode 100644 criu/include/sigaction.h
>>>>
>>>> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
>>>> new file mode 100644
>>>> index 00000000..ceafade3
>>>> --- /dev/null
>>>> +++ b/criu/include/sigaction.h
>>>> @@ -0,0 +1,38 @@
>>>> +#ifndef __CR_SIGACTION_H__
>>>> +#define __CR_SIGACTION_H__
>>>> +
>>>> +
>>>> +#include <sys/un.h>
>>>> +#include <sys/time.h>
>>>> +
>>>> +#include <unistd.h>
>>>> +#include <inttypes.h>
>>>> +
>>>> +#include "parasite.h"
>>>> +#include "parasite-syscall.h"
>>>> +#include "pstree.h"
>>>> +#include "sigframe.h" //TaskCoreEntry, SaEntry
>>>> +
>>>> +#include "image.h"
>>>> +#include "img-remote.h"
>>>> +#include "images/core.pb-c.h"
>>>> +#include "images/sa.pb-c.h"
>>>> +#include "infect.h"
>>>> +#include "infect-rpc.h"
>>>> +#include "parasite.h"
>>>> +#include "util-pie.h"
>>>> +
>>>> +#include <compel/compel.h>
>>>> +#include "restore.h"
>>>> +#include "restorer.h"
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +extern rt_sigaction_t sigchld_act;
>>>> +
>>>> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct pstree_item *item);
>>>> +
>>>> +int prepare_sigactions(CoreEntry *core);
>>>> +
>>>> +#endif
>>>> --
>>>> 2.17.1
>>>>
>>>> _______________________________________________
>>>> CRIU mailing list
>>>> CRIU@openvz.org
>>>> https://lists.openvz.org/mailman/listinfo/criu
>
> _______________________________________________
> CRIU mailing list
> CRIU@openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
prakriti goyal March 17, 2020, 8:33 a.m.
I'm sorry for the inconvenience caused. I'm working on a new patch and will
send them as soon as possible.

Also, I'm really thankful for your suggestions.

Regards,
Prakriti Goyal


On Tue, Mar 17, 2020 at 1:43 PM Pavel Tikhomirov <snorcht@gmail.com> wrote:

> I think we also need some description why we move this functions in
> patch subject and description.
>
> Also please remove extra empty lines and spaces in the end of lines.
>
> Best Regards, Tikhomirov Pavel.
>
> вт, 17 мар. 2020 г. в 11:00, Pavel Emelyanov <ovzxemul@gmail.com>:
> >
> > Don't drop mailing list from responses.
> >
> > вт, 17 мар. 2020 г. в 10:50, prakriti goyal <prakritigoyal19@gmail.com>:
> >>
> >> I'm sorry I'm not familiar with how git format-patch works and worked
> with it for the first time. This caused a lot of patches to be submitted.
> >>
> >> The main patch is the [2/9].
> >>
> >
> > Please, either push another branch, or send another set of patches (or
> both) and make sure
> > the patches we see on the mailing list and the branch you point to
> contain identical patches.
> >
> > -- Pavel
> >
> >>
> >> On Tue 17 Mar, 2020, 12:52 PM Pavel Emelyanov, <ovzxemul@gmail.com>
> wrote:
> >>>
> >>>
> >>>
> >>> пн, 16 мар. 2020 г. в 19:02, prakriti goyal <prakritigoyal19@gmail.com
> >:
> >>>>
> >>>> From: prakritigoyal19 <prakritigoyal19@gmail.com>
> >>>>
> >>>> Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
> >>>> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions
> >>>>
> >>>
> >>> This branch contains different set of patches. Why is that so?
> >>>
> >>> -- Pavel
> >>>
> >>>>
> >>>> ---
> >>>>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
> >>>>  1 file changed, 38 insertions(+)
> >>>>  create mode 100644 criu/include/sigaction.h
> >>>>
> >>>> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
> >>>> new file mode 100644
> >>>> index 00000000..ceafade3
> >>>> --- /dev/null
> >>>> +++ b/criu/include/sigaction.h
> >>>> @@ -0,0 +1,38 @@
> >>>> +#ifndef __CR_SIGACTION_H__
> >>>> +#define __CR_SIGACTION_H__
> >>>> +
> >>>> +
> >>>> +#include <sys/un.h>
> >>>> +#include <sys/time.h>
> >>>> +
> >>>> +#include <unistd.h>
> >>>> +#include <inttypes.h>
> >>>> +
> >>>> +#include "parasite.h"
> >>>> +#include "parasite-syscall.h"
> >>>> +#include "pstree.h"
> >>>> +#include "sigframe.h" //TaskCoreEntry, SaEntry
> >>>> +
> >>>> +#include "image.h"
> >>>> +#include "img-remote.h"
> >>>> +#include "images/core.pb-c.h"
> >>>> +#include "images/sa.pb-c.h"
> >>>> +#include "infect.h"
> >>>> +#include "infect-rpc.h"
> >>>> +#include "parasite.h"
> >>>> +#include "util-pie.h"
> >>>> +
> >>>> +#include <compel/compel.h>
> >>>> +#include "restore.h"
> >>>> +#include "restorer.h"
> >>>> +
> >>>> +
> >>>> +
> >>>> +
> >>>> +extern rt_sigaction_t sigchld_act;
> >>>> +
> >>>> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct
> pstree_item *item);
> >>>> +
> >>>> +int prepare_sigactions(CoreEntry *core);
> >>>> +
> >>>> +#endif
> >>>> --
> >>>> 2.17.1
> >>>>
> >>>> _______________________________________________
> >>>> CRIU mailing list
> >>>> CRIU@openvz.org
> >>>> https://lists.openvz.org/mailman/listinfo/criu
> >
> > _______________________________________________
> > CRIU mailing list
> > CRIU@openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu
>
Mike Rapoport March 17, 2020, 10:37 a.m.
Hello,

On Mon, Mar 16, 2020 at 09:29:28PM +0530, prakriti goyal wrote:
> From: prakritigoyal19 <prakritigoyal19@gmail.com>
> 
> Signed-off-by: prakritigoyal19 <prakritigoyal19@gmail.com>
> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions

We are accepting pull requests for a while now, so you can use that if you
prefer.
If you would like to still send patches to the mailing list, please
consider adding --cover-letter option to 'git send-email'. This will
generate a message that is intended for overall description of the series.
Still, each commit (patch) in the series should have a clear description
why the change is performed and what is the change.
 
> ---
>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 criu/include/sigaction.h
> 
> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
> new file mode 100644
> index 00000000..ceafade3
> --- /dev/null
> +++ b/criu/include/sigaction.h
> @@ -0,0 +1,38 @@
> +#ifndef __CR_SIGACTION_H__
> +#define __CR_SIGACTION_H__
> +
> +
> +#include <sys/un.h>
> +#include <sys/time.h>
> +
> +#include <unistd.h>
> +#include <inttypes.h>
> +
> +#include "parasite.h"
> +#include "parasite-syscall.h"
> +#include "pstree.h"
> +#include "sigframe.h" //TaskCoreEntry, SaEntry
> +
> +#include "image.h"
> +#include "img-remote.h"
> +#include "images/core.pb-c.h"
> +#include "images/sa.pb-c.h"
> +#include "infect.h"
> +#include "infect-rpc.h"
> +#include "parasite.h"
> +#include "util-pie.h"
> +
> +#include <compel/compel.h>
> +#include "restore.h"
> +#include "restorer.h"

Are all these headers really needed here?

> +
> +
> +
> +
> +extern rt_sigaction_t sigchld_act;
> +
> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct pstree_item *item);
> +
> +int prepare_sigactions(CoreEntry *core);
> +
> +#endif
> -- 
> 2.17.1