[RH7,1/6] x86/asm: Use register variable to get stack pointer value

Submitted by Kirill Tkhai on May 22, 2020, 5:02 p.m.


Message ID 159016697183.337057.11378766454672430441.stgit@localhost.localdomain
State New
Series "Introduce down_read_killable()"
Headers show

Commit Message

Kirill Tkhai May 22, 2020, 5:02 p.m.
From: Andrey Ryabinin <aryabinin@virtuozzo.com>

ms commit 196bd485ee4f (part)

Currently we use current_stack_pointer() function to get the value
of the stack pointer register. Since commit:

f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang")

... we have a stack register variable declared. It can be used instead of
current_stack_pointer() function which allows to optimize away some
excessive "mov %rsp, %<dst>" instructions:

  -mov    %rsp,%rdx
  -sub    %rdx,%rax
  -cmp    $0x3fff,%rax
  -ja     ffffffff810722fd <ist_begin_non_atomic+0x2d>

  +sub    %rsp,%rax
  +cmp    $0x3fff,%rax
  +ja     ffffffff810722fa <ist_begin_non_atomic+0x2a>

Remove current_stack_pointer(), rename __asm_call_sp to current_stack_pointer
and use it instead of the removed function.

Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170929141537.29167-1-aryabinin@virtuozzo.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
 arch/x86/include/asm/asm.h |    5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h
index 41efcf174633..b15820cf90d2 100644
--- a/arch/x86/include/asm/asm.h
+++ b/arch/x86/include/asm/asm.h
@@ -83,4 +83,9 @@ 
 	" .popsection\n"
+#ifndef __ASSEMBLY__
+register unsigned long current_stack_pointer asm(_ASM_SP);
+#define ASM_CALL_CONSTRAINT "+r" (current_stack_pointer)
 #endif /* _ASM_X86_ASM_H */