[RHEL7,COMMIT] ext4: ext4_file_dio_write(): switch to iov_iter

Submitted by Konstantin Khorenko on May 25, 2020, 2:52 p.m.


Message ID 202005251452.04PEqUAP004590@finist-ce7.sw.ru
State New
Series "fs, direct_IO: Switch to iov_iter and allow bio_vec for ext4"
Headers show

Commit Message

Konstantin Khorenko May 25, 2020, 2:52 p.m.
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.161.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1127.8.2.vz7.161.1
commit 31329c30920eb2b3baaefc2c0a7a1e47963c86b9
Author: Kirill Tkhai <ktkhai@virtuozzo.com>
Date:   Mon May 25 17:52:29 2020 +0300

    ext4: ext4_file_dio_write(): switch to iov_iter
    Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
    Patchset description:
    [00/30] fs,direct_IO: Switch to iov_iter and allow bio_vec for ext4
    This patchset transforms direct_IO callbacks, blockdev_direct_IO
    and its underlining functions to iov_iter, and introduces complete
    support of iov_iter for ext4.
    Supported iov_iter subtypes for ext4 is iovec and bio_vec. The first
    is for traditional user-submitted aio, while bio_vec is the type,
    which is important for us, since we use it in ploop.
    bio_vec operates with pages instead of user addresses (like iovec
    does), so it requires specific callbacks in do_blockdev_direct_IO()
    and in the functions it calls.
    The patchset reworks do_blockdev_direct_IO() in the same manner
    as in mainstrean. The most of rest patches are prepared manually,
    since we have significant differences to ms (RHEL7 patches, our
    direct IO patches for FUSE; all they have changed many functions).
    At the end, kaio engine (resulting in direct_IO) became possible
    to be enabled for ext4.
 fs/ext4/file.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

Patch hide | download patch | download mbox

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index fefcbb809bf37..3adbb7b72c5ae 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -79,12 +79,10 @@  static void ext4_unwritten_wait(struct inode *inode)
  * or one thread will zero the other's data, causing corruption.
 static int
-ext4_unaligned_aio(struct inode *inode, const struct iovec *iov,
-		   unsigned long nr_segs, loff_t pos)
+ext4_unaligned_aio(struct inode *inode, size_t count, loff_t pos)
 	struct super_block *sb = inode->i_sb;
 	int blockmask = sb->s_blocksize - 1;
-	size_t count = iov_length(iov, nr_segs);
 	loff_t final_size = pos + count;
 	if (pos >= ALIGN(i_size_read(inode), sb->s_blocksize))
@@ -154,8 +152,7 @@  static ssize_t ext4_write_checks(struct kiocb *iocb, const struct iovec *iov,
 static ssize_t
-ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,
-		    unsigned long nr_segs, loff_t pos)
+ext4_file_dio_write(struct kiocb *iocb, struct iov_iter *iter, loff_t pos)
 	struct file *file = iocb->ki_filp;
 	struct inode *inode = file->f_mapping->host;
@@ -163,10 +160,11 @@  ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,
 	int unaligned_aio = 0;
 	ssize_t ret;
 	int overwrite = 0;
+	size_t count = iov_iter_count(iter);
 	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS) &&
-		unaligned_aio = ext4_unaligned_aio(inode, iov, nr_segs, pos);
+		unaligned_aio = ext4_unaligned_aio(inode, count, pos);
 	/* Unaligned direct AIO must be serialized; see comment above */
 	if (unaligned_aio) {
@@ -183,10 +181,10 @@  ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,
 	/* Check whether we do a DIO overwrite or not */
 	if (ext4_should_dioread_nolock(inode) && !unaligned_aio &&
-	    ext4_overwrite_io(inode, iocb->ki_pos, iov_length(iov, nr_segs)))
+	    ext4_overwrite_io(inode, iocb->ki_pos, count))
 		overwrite = 1;
-	ret = __generic_file_aio_write(iocb, iov, nr_segs, &iocb->ki_pos);
+	ret = __generic_file_write_iter(iocb, iter, &iocb->ki_pos);
 	 * Unaligned direct AIO must be the only IO in flight. Otherwise
 	 * overlapping aligned IO after unaligned might result in data
@@ -267,9 +265,13 @@  ext4_file_write(struct kiocb *iocb, const struct iovec *iov,
 	iocb->private = &overwrite; /* RHEL7 only - prevent DIO race */
-	if (unlikely(io_is_direct(iocb->ki_filp)))
-		ret = ext4_file_dio_write(iocb, iov, nr_segs, pos);
-	else
+	if (unlikely(io_is_direct(iocb->ki_filp))) {
+		struct iov_iter iter;
+		iov_iter_init(&iter, iov, nr_segs, iov_length(iov, nr_segs), 0);
+		ret = ext4_file_dio_write(iocb, &iter, pos);
+	} else
 		ret = generic_file_aio_write(iocb, iov, nr_segs, pos);
 	return ret;