arch/x86: Fix calculation of xstate_size

Submitted by Cyrill Gorcunov on May 31, 2020, 8:51 p.m.

Details

Message ID 20200531205131.GP215590@grain
State New
Headers show

Pull-request download mbox

git pull https://github.com/cyrillos/criu x86-xstate-fix

Comments

Cyrill Gorcunov June 1, 2020, 8:28 a.m.
On Mon, Jun 01, 2020 at 09:17:34AM +0100, Radostin Stoyanov wrote:
> 
> 
> On 31/05/2020 21:51, Cyrill Gorcunov wrote:
> > On Sun, May 31, 2020 at 12:57:30PM -0700, Andrei Vagin wrote:
> > > > > Dima, could you review this patch?
> > > > > Cyrill, could you create a pull-request on github?
> > > > Andrew, I wonder -- now all patch should go via PR?
> > > yes. This is the preferred way.
> > but emails must be acceptable still, right? I've no clue
> > how to make a pull request between different repositories
> > via github web interface.
> Hi Cyrill, you should be able to open a pull request with this link:
> 
> https://github.com/cyrillos/criu/compare/criu-dev...x86-xstate-fix
> 
> I have attached a screenshot with circles around base branch, fork-ed branch
> and the button that will open a pull request.

Done. https://github.com/cyrillos/criu/pull/21

Actually I don't understand how this supposed to work with checkpoint-restore/criu
repository. You guys gonna review it on my repo and the fetch into
checkpoint-restore?

As by experience from LKML we usually provide a branch to fetch but review
procedure comes via emails. I must confess I really dislike all this modern
review procedures via some vague web interface :)
Radostin Stoyanov June 1, 2020, 10:09 a.m.
On 01/06/2020 09:28, Cyrill Gorcunov wrote:
> On Mon, Jun 01, 2020 at 09:17:34AM +0100, Radostin Stoyanov wrote:
>>
>> On 31/05/2020 21:51, Cyrill Gorcunov wrote:
>>> On Sun, May 31, 2020 at 12:57:30PM -0700, Andrei Vagin wrote:
>>>>>> Dima, could you review this patch?
>>>>>> Cyrill, could you create a pull-request on github?
>>>>> Andrew, I wonder -- now all patch should go via PR?
>>>> yes. This is the preferred way.
>>> but emails must be acceptable still, right? I've no clue
>>> how to make a pull request between different repositories
>>> via github web interface.
>> Hi Cyrill, you should be able to open a pull request with this link:
>>
>> https://github.com/cyrillos/criu/compare/criu-dev...x86-xstate-fix
>>
>> I have attached a screenshot with circles around base branch, fork-ed branch
>> and the button that will open a pull request.
> Done. https://github.com/cyrillos/criu/pull/21
It looks like GitHub doesn't know that your repository is a fork of 
https://github.com/checkpoint-restore/criu

You should be able to fix this by:
1. Rename your repository https://github.com/cyrillos/criu/settings (see 
fig1.png)
2. Create a fork of https://github.com/checkpoint-restore/criu (see 
fig2.png)

Then you need to push the x86-xstate-fix branch again and open a pull 
request with this link:
https://github.com/checkpoint-restore/criu/compare/criu-dev...cyrillos:x86-xstate-fix

> Actually I don't understand how this supposed to work with checkpoint-restore/criu
> repository. You guys gonna review it on my repo and the fetch into
> checkpoint-restore?
>
> As by experience from LKML we usually provide a branch to fetch but review
> procedure comes via emails. I must confess I really dislike all this modern
> review procedures via some vague web interface :)
Cyrill Gorcunov June 1, 2020, 10:26 a.m.
On Mon, Jun 01, 2020 at 11:09:01AM +0100, Radostin Stoyanov wrote:
> 
> You should be able to fix this by:
> 1. Rename your repository https://github.com/cyrillos/criu/settings (see
> fig1.png)
> 2. Create a fork of https://github.com/checkpoint-restore/criu (see
> fig2.png)
> 
> Then you need to push the x86-xstate-fix branch again and open a pull
> request with this link:
> https://github.com/checkpoint-restore/criu/compare/criu-dev...cyrillos:x86-xstate-fix

Ah, the real reason is that my criu repo has been cated before the main one.
Thanks! I'll fix once time permit.