[RHEL7,COMMIT] ms/xfs: fix boundary test in xfs_attr_shortform_verify

Submitted by Vasily Averin on Sept. 9, 2020, 10:41 a.m.


Message ID 202009091041.089AfvE6031581@vz7build.vvs.sw.ru
State New
Series "ms/xfs: fix boundary test in xfs_attr_shortform_verify"
Headers show

Commit Message

Vasily Averin Sept. 9, 2020, 10:41 a.m.
The commit is pushed to "branch-rh7-3.10.0-1127.18.2.vz7.163.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1127.18.2.vz7.163.18
commit 2bde8a6068ba41cad1394863e30a3ec6e124388d
Author: Vasily Averin <vvs@virtuozzo.com>
Date:   Wed Sep 9 13:41:57 2020 +0300

    ms/xfs: fix boundary test in xfs_attr_shortform_verify
    The boundary test for the fixed-offset parts of xfs_attr_sf_entry in
    xfs_attr_shortform_verify is off by one, because the variable array
    at the end is defined as nameval[1] not nameval[].
    Hence we need to subtract 1 from the calculation.
    This can be shown by:
    # touch file
    # setfattr -n root.a file
    and verifications will fail when it's written to disk.
    This only matters for a last attribute which has a single-byte name
    and no value, otherwise the combination of namelen & valuelen will
    push endp further out and this test won't fail.
    Fixes: 1e1bbd8e7ee06 ("xfs: create structure verifier function for shortform xattrs")
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    (Cherry-picked mainline f4020438fab05364018c91f7e02ebdd192085933)
    Fixes CVE-2020-14385
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
 fs/xfs/libxfs/xfs_attr_leaf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
index 7438ce7..559ab99 100644
--- a/fs/xfs/libxfs/xfs_attr_leaf.c
+++ b/fs/xfs/libxfs/xfs_attr_leaf.c
@@ -921,8 +921,10 @@  xfs_attr_shortform_verify(
 		 * struct xfs_attr_sf_entry has a variable length.
 		 * Check the fixed-offset parts of the structure are
 		 * within the data buffer.
+		 * xfs_attr_sf_entry is defined with a 1-byte variable
+		 * array at the end, so we must subtract that off.
-		if (((char *)sfep + sizeof(*sfep)) >= endp)
+		if (((char *)sfep + sizeof(*sfep) - 1) >= endp)
 			return __this_address;
 		/* Don't allow names with known bad length. */