From patchwork Sat Sep 19 16:51:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RH7,3/4] ploop: Add comments about fsync_thread From: Kirill Tkhai X-Patchwork-Id: 13495 Message-Id: <160053428359.24001.17114557372123533320.stgit@qvm3002.qa.sw.ru> To: ktkhai@virtuozzo.com, vvs@virtuozzo.com, khorenko@virtuozzo.com, devel@openvz.org Date: Sat, 19 Sep 2020 19:51:29 +0300 Signed-off-by: Kirill Tkhai --- drivers/block/ploop/io_kaio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c index 19d9b0a..3af9eba 100644 --- a/drivers/block/ploop/io_kaio.c +++ b/drivers/block/ploop/io_kaio.c @@ -546,6 +546,11 @@ static int kaio_fsync_thread(void * data) } else if (preq->req_rw & REQ_FLUSH) { BUG_ON(!preq->req_size); preq->req_rw &= ~REQ_FLUSH; + /* + * FIXME: We submit some data and main thread + * is not synchronized with this? Also, + * TODO: fsync_thread must care of ploop_quiesce(). + */ if (kaio_resubmit(preq)) { spin_lock_irq(&plo->lock); continue;