[RHEL7,COMMIT] ploop: Add comments about fsync_thread

Submitted by Vasily Averin on Sept. 20, 2020, 9:02 a.m.

Details

Message ID 202009200902.08K92TSI015897@vz7build.vvs.sw.ru
State New
Series "Series without cover letter"
Headers show

Commit Message

Vasily Averin Sept. 20, 2020, 9:02 a.m.
The commit is pushed to "branch-rh7-3.10.0-1127.18.2.vz7.163.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1127.18.2.vz7.163.26
------>
commit 46ac1541c7179c1d75bc4ac2ee7ed67872830a9a
Author: Kirill Tkhai <ktkhai@virtuozzo.com>
Date:   Sun Sep 20 12:02:29 2020 +0300

    ploop: Add comments about fsync_thread
    
    https://jira.sw.ru/browse/PSBM-108008
    Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
 drivers/block/ploop/io_kaio.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c
index 19d9b0a..3af9eba 100644
--- a/drivers/block/ploop/io_kaio.c
+++ b/drivers/block/ploop/io_kaio.c
@@ -546,6 +546,11 @@  static int kaio_fsync_thread(void * data)
 			} else if (preq->req_rw & REQ_FLUSH) {
 				BUG_ON(!preq->req_size);
 				preq->req_rw &= ~REQ_FLUSH;
+				/*
+				 * FIXME: We submit some data and main thread
+				 * is not synchronized with this? Also,
+				 * TODO: fsync_thread must care of ploop_quiesce().
+				 */
 				if (kaio_resubmit(preq)) {
 					spin_lock_irq(&plo->lock);
 					continue;