Re: [PATCH v3] posix_fallocate.3: add EOPNOTSUPP error code.

Submitted by Érico Rolim on Oct. 26, 2020, 11:21 p.m.

Details

Message ID CAFDeuWNrOMC=qrTLXdRO01ZUrBCKttn7+TWHDqr9hkTWS0QiyA@mail.gmail.com
State New
Series "posix_fallocate.3: add note about error codes for musl."
Headers show

Commit Message

Érico Rolim Oct. 26, 2020, 11:21 p.m.
As can be seen in

https://git.musl-libc.org/cgit/musl/tree/src/fcntl/posix_fallocate.c?id=73cc775bee53300c7cf759f37580220b18ac13d3

musl libc returns the syscall's errors directly, which means it doesn't
perform the same emulation as glibc, and can return EOPNOTSUPP to an
application, which isnt't listed in ERRORS.
---

Made a small correction to the formatting for fd.

 man3/posix_fallocate.3 | 7 +++++++
 1 file changed, 7 insertions(+)

 refers to a pipe.

Patch hide | download patch | download mbox

diff --git a/man3/posix_fallocate.3 b/man3/posix_fallocate.3
index 3152dd54f..8ea37261a 100644
--- a/man3/posix_fallocate.3
+++ b/man3/posix_fallocate.3
@@ -98,6 +98,13 @@  There is not enough space left on the device
containing the file
 referred to by
 .IR fd .
 .TP
+.B EOPNOTSUPP
+The filesystem containing the file referred to by
+.I fd
+does not support this operation.
+This error code can be returned by libc's that don't perform the
+emulation shown in NOTES, such as musl libc.
+.TP
 .B ESPIPE
 .I fd

Comments

Michael Kerrisk (man-pages) Oct. 27, 2020, 7:02 a.m.
Hello Éric,

On 10/27/20 12:21 AM, Érico Rolim wrote:
> As can be seen in
> 
> https://git.musl-libc.org/cgit/musl/tree/src/fcntl/posix_fallocate.c?id=73cc775bee53300c7cf759f37580220b18ac13d3
> 
> musl libc returns the syscall's errors directly, which means it doesn't
> perform the same emulation as glibc, and can return EOPNOTSUPP to an
> application, which isnt't listed in ERRORS.

Thanks. Patch applied.

(By the way, your mailer is wrapping text in the patch;
I manually fixed.)

Thanks,

Michael

> ---
> 
> Made a small correction to the formatting for fd.
> 
>  man3/posix_fallocate.3 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/man3/posix_fallocate.3 b/man3/posix_fallocate.3
> index 3152dd54f..8ea37261a 100644
> --- a/man3/posix_fallocate.3
> +++ b/man3/posix_fallocate.3
> @@ -98,6 +98,13 @@ There is not enough space left on the device
> containing the file
>  referred to by
>  .IR fd .
>  .TP
> +.B EOPNOTSUPP
> +The filesystem containing the file referred to by
> +.I fd
> +does not support this operation.
> +This error code can be returned by libc's that don't perform the
> +emulation shown in NOTES, such as musl libc.
> +.TP
>  .B ESPIPE
>  .I fd
>  refers to a pipe.
>