[RHEL7,COMMIT] cpufreq: intel_pstate: Make reasons for failure more visible

Submitted by Vasily Averin on March 2, 2021, 6:53 a.m.

Details

Message ID 202103020653.1226r1wK028135@vz7build.vvs.sw.ru
State New
Series "intel_pstate: add prints to record why the driver refused to work (PSBM-126007)"
Headers show

Commit Message

Vasily Averin March 2, 2021, 6:53 a.m.
The commit is pushed to "branch-rh7-3.10.0-1160.15.2.vz7.173.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-1160.15.2.vz7.173.1
------>
commit 6b75db563ee86e3f2637078b685604a3658ab655
Author: Evgenii Shatokhin <eshatokhin@virtuozzo.com>
Date:   Tue Mar 2 09:53:01 2021 +0300

    cpufreq: intel_pstate: Make reasons for failure more visible
    
    Our current kernels have intel_pstate built-in. Its probing routines run
    at boot and may fail (e.g. when an unsupported CPUs or certain BIOS features
    are detected). The reason of such failures needs to be clearly visible in
    the logs.
    
    Enabling the relevant pr_debug() messages in runtime is not very convenient.
    pr_info() messages are also easy to miss. Let us make all these more visible
    in dmesg.
    
    Added in the scope of https://jira.sw.ru/browse/PSBM-126007.
    Signed-off-by: Evgenii Shatokhin <eshatokhin@virtuozzo.com>
---
 drivers/cpufreq/intel_pstate.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 4283d1b..f5a8f45 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2409,7 +2409,7 @@  static bool intel_pstate_no_acpi_pss(void)
 		kfree(pss);
 	}
 
-	pr_debug("ACPI _PSS not found\n");
+	pr_notice("ACPI _PSS not found\n");
 	return true;
 }
 
@@ -2426,7 +2426,7 @@  static bool __init intel_pstate_no_acpi_pcch(void)
 		return false;
 
 not_found:
-	pr_debug("ACPI PCCH not found\n");
+	pr_notice("ACPI PCCH not found\n");
 	return true;
 }
 
@@ -2442,7 +2442,7 @@  static bool intel_pstate_has_acpi_ppc(void)
 		if (acpi_has_method(pr->handle, "_PPC"))
 			return true;
 	}
-	pr_debug("ACPI _PPC not found\n");
+	pr_notice("ACPI _PPC not found\n");
 	return false;
 }
 
@@ -2489,7 +2489,7 @@  static bool intel_pstate_platform_pwr_mgmt_exists(void)
 	if (id) {
 		rdmsrl(MSR_MISC_PWR_MGMT, misc_pwr);
 		if (misc_pwr & (1 << 8)) {
-			pr_debug("Bit 8 in the MISC_PWR_MGMT MSR set\n");
+			pr_notice("Bit 8 in the MISC_PWR_MGMT MSR set\n");
 			return true;
 		}
 	}
@@ -2560,7 +2560,7 @@  static int __init intel_pstate_init(void)
 
 		id = x86_match_cpu(intel_pstate_cpu_ids);
 		if (!id) {
-			pr_info("CPU ID not supported\n");
+			pr_notice("CPU ID not supported\n");
 			return -ENODEV;
 		}
 
@@ -2568,7 +2568,7 @@  static int __init intel_pstate_init(void)
 	}
 
 	if (intel_pstate_msrs_not_valid()) {
-		pr_info("Invalid MSRs\n");
+		pr_notice("Invalid MSRs\n");
 		return -ENODEV;
 	}
 
@@ -2578,7 +2578,7 @@  hwp_cpu_matched:
 	 * firmware has its own power management modes.
 	 */
 	if (intel_pstate_platform_pwr_mgmt_exists()) {
-		pr_info("P-states controlled by the platform\n");
+		pr_notice("P-states controlled by the platform\n");
 		return -ENODEV;
 	}