tty: Deprecate no-regfile entry case

Submitted by Pavel Emelianov on Sept. 1, 2016, 4:08 p.m.

Details

Message ID 57C85282.7040907@virtuozzo.com
State Rejected
Series "tty: Deprecate no-regfile entry case"
Headers show

Commit Message

Pavel Emelianov Sept. 1, 2016, 4:08 p.m.
TTY files carry link on regfile entry since 1.4 (commit caa64d97)

Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
---
 criu/tty.c | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/criu/tty.c b/criu/tty.c
index 3eda281..b152685 100644
--- a/criu/tty.c
+++ b/criu/tty.c
@@ -1541,6 +1541,9 @@  static int collect_one_tty(void *obj, ProtobufCMessage *msg, struct cr_img *i)
 	 */
 	info->reg_d = try_collect_special_file(info->tfe->id, 1);
 	if (!info->reg_d) {
+		if (!deprecated_ok("TTY w/o regfile"))
+			return -1;
+
 		if (is_pty(info->driver)) {
 			info->reg_d = pty_alloc_reg(info, true);
 			if (!info->reg_d) {

Comments

Cyrill Gorcunov Sept. 1, 2016, 4:22 p.m.
On Thu, Sep 01, 2016 at 07:08:34PM +0300, Pavel Emelyanov wrote:
> TTY files carry link on regfile entry since 1.4 (commit caa64d97)
> 
> Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>