[Devel,rh7,2/2] ms/dm: remove dummy definition of 'struct dm_table'

Submitted by Andrey Ryabinin on Sept. 22, 2016, 4:44 p.m.

Details

Message ID 1474562674-29413-2-git-send-email-aryabinin@virtuozzo.com
State New
Series "Series without cover letter"
Headers show

Commit Message

Andrey Ryabinin Sept. 22, 2016, 4:44 p.m.
There is no need for it.

https://jira.sw.ru/browse/PSBM-50727

Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 drivers/md/dm-ioctl.c | 8 --------
 1 file changed, 8 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 720ceeb..0fe4233 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -36,14 +36,6 @@  struct hash_cell {
 	struct dm_table *new_map;
 };
 
-/*
- * A dummy definition to make RCU happy.
- * struct dm_table should never be dereferenced in this file.
- */
-struct dm_table {
-	int undefined__;
-};
-
 struct vers_iter {
     size_t param_size;
     struct dm_target_versions *vers, *old_vers;

Comments

Konstantin Khorenko Sept. 23, 2016, 2:13 p.m.
Why mainstream still keeps it?

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 09/22/2016 07:44 PM, Andrey Ryabinin wrote:
> There is no need for it.
>
> https://jira.sw.ru/browse/PSBM-50727
>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
>  drivers/md/dm-ioctl.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
> index 720ceeb..0fe4233 100644
> --- a/drivers/md/dm-ioctl.c
> +++ b/drivers/md/dm-ioctl.c
> @@ -36,14 +36,6 @@ struct hash_cell {
>  	struct dm_table *new_map;
>  };
>
> -/*
> - * A dummy definition to make RCU happy.
> - * struct dm_table should never be dereferenced in this file.
> - */
> -struct dm_table {
> -	int undefined__;
> -};
> -
>  struct vers_iter {
>      size_t param_size;
>      struct dm_target_versions *vers, *old_vers;
>
Andrey Ryabinin Sept. 23, 2016, 2:35 p.m.
On 09/23/2016 05:13 PM, Konstantin Khorenko wrote:
> Why mainstream still keeps it?
> 

By mistake, I guess.

> -- 
> Best regards,
> 
> Konstantin Khorenko,
> Virtuozzo Linux Kernel Team
> 
> On 09/22/2016 07:44 PM, Andrey Ryabinin wrote:
>> There is no need for it.
>>
>> https://jira.sw.ru/browse/PSBM-50727
>>
>> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>> ---
>>  drivers/md/dm-ioctl.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
>> index 720ceeb..0fe4233 100644
>> --- a/drivers/md/dm-ioctl.c
>> +++ b/drivers/md/dm-ioctl.c
>> @@ -36,14 +36,6 @@ struct hash_cell {
>>      struct dm_table *new_map;
>>  };
>>
>> -/*
>> - * A dummy definition to make RCU happy.
>> - * struct dm_table should never be dereferenced in this file.
>> - */
>> -struct dm_table {
>> -    int undefined__;
>> -};
>> -
>>  struct vers_iter {
>>      size_t param_size;
>>      struct dm_target_versions *vers, *old_vers;
>>