[Devel,rh7] ms/coredump: fix unfreezable coredumping task

Submitted by Andrey Ryabinin on Oct. 3, 2016, 1:34 p.m.

Details

Message ID 1475501649-10535-1-git-send-email-aryabinin@virtuozzo.com
State New
Series "ms/coredump: fix unfreezable coredumping task"
Headers show

Commit Message

Andrey Ryabinin Oct. 3, 2016, 1:34 p.m.
It could be not possible to freeze coredumping task when it waits
for 'core_state->startup' completion, because threads are frozen
in get_signal() before they got a chance to complete 'core_state->startup'.

Use freezer_do_not_count() to tell freezer to ignore coredumping
task while it waits for core_state->startup completion.

https://jira.sw.ru/browse/PSBM-52793

Link: http://lkml.kernel.org/r/1475225434-3753-1-git-send-email-aryabinin@virtuozzo.com
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: stable@vger.kernel.org
Acked-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
 fs/coredump.c | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/fs/coredump.c b/fs/coredump.c
index e3fdee2..f6a1012 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1,6 +1,7 @@ 
 #include <linux/slab.h>
 #include <linux/file.h>
 #include <linux/fdtable.h>
+#include <linux/freezer.h>
 #include <linux/mm.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>
@@ -388,7 +389,9 @@  static int coredump_wait(int exit_code, struct core_state *core_state)
 	if (core_waiters > 0) {
 		struct core_thread *ptr;
 
+		freezer_do_not_count();
 		wait_for_completion(&core_state->startup);
+		freezer_count();
 		/*
 		 * Wait for all the threads to become inactive, so that
 		 * all the thread context (extended register state, like

Comments

Dmitry Safonov Oct. 3, 2016, 1:45 p.m.
On 10/03/2016 04:34 PM, Andrey Ryabinin wrote:
> It could be not possible to freeze coredumping task when it waits
> for 'core_state->startup' completion, because threads are frozen
> in get_signal() before they got a chance to complete 'core_state->startup'.
>
> Use freezer_do_not_count() to tell freezer to ignore coredumping
> task while it waits for core_state->startup completion.
>
> https://jira.sw.ru/browse/PSBM-52793
>
> Link: http://lkml.kernel.org/r/1475225434-3753-1-git-send-email-aryabinin@virtuozzo.com
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: stable@vger.kernel.org
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>

Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>