[Devel] ext4: fix mkdir operations with overlayfs

Submitted by Vladimir Meshkov on Oct. 14, 2016, 4:47 p.m.

Details

Message ID CADgqXfJQCZfLCjTkfRoLJJyo_YMco_7yoK4xaK3CuHjF6nsChQ@mail.gmail.com
State New
Series "ext4: fix mkdir operations with overlayfs"
Headers show

Commit Message

Vladimir Meshkov Oct. 14, 2016, 4:47 p.m.
ext4 supports an extended operations like rename2, but
inode isn't correctly marked after mkdir.

Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com
<https://e.mail.ru/compose?To=umka@cloudlinux.com>>
---
 fs/ext4/namei.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 0adc6df..bebe698 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2413,6 +2413,7 @@  retry:

  inode->i_op = &ext4_dir_inode_operations.ops;
  inode->i_fop = &ext4_dir_operations;
+ inode->i_flags |= S_IOPS_WRAPPER;
  err = ext4_init_new_dir(handle, dir, inode);
  if (err)
  goto out_clear_inode;

Comments

Maxim Patlasov Oct. 14, 2016, 6:23 p.m.
Thanks! You may be interested to search devel@openvz.org archives for:

Subject: [PATCH rh7] ext4: ext4_mkdir must set S_IOPS_WRAPPER bit

Date: Mon, 25 Jul 2016 14:01:16 -0700


On 10/14/2016 09:47 AM, Vladimir Meshkov wrote:
> ext4 supports an extended operations like rename2, but
> inode isn't correctly marked after mkdir.
>
> Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com 
> <https://e.mail.ru/compose?To=umka@cloudlinux.com>>
> ---
>  fs/ext4/namei.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 0adc6df..bebe698 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2413,6 +2413,7 @@ retry:
>
>   inode->i_op = &ext4_dir_inode_operations.ops;
>   inode->i_fop = &ext4_dir_operations;
> + inode->i_flags |= S_IOPS_WRAPPER;
>   err = ext4_init_new_dir(handle, dir, inode);
>   if (err)
>   goto out_clear_inode;
> -- 
> 1.8.3.1
>
>
> _______________________________________________
> Devel mailing list
> Devel@openvz.org
> https://lists.openvz.org/mailman/listinfo/devel
Vladimir Meshkov Oct. 17, 2016, 8:48 a.m.
Could you please clarify why we cannot find the commit at
https://src.openvz.org/projects/OVZ/repos/vzkernel/browse/fs/ext4/namei.c?at=refs/heads/branch-rh7-3.10.0-327.36.1.vz7.18.x-ovz
? Thank you.

On Fri, Oct 14, 2016 at 9:23 PM, Maxim Patlasov <mpatlasov@virtuozzo.com>
wrote:

> Thanks! You may be interested to search devel@openvz.org archives for:
>
> Subject: [PATCH rh7] ext4: ext4_mkdir must set S_IOPS_WRAPPER bit
>
> Date: Mon, 25 Jul 2016 14:01:16 -0700
>
> On 10/14/2016 09:47 AM, Vladimir Meshkov wrote:
>
> ext4 supports an extended operations like rename2, but
> inode isn't correctly marked after mkdir.
>
> Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com
> <https://e.mail.ru/compose?To=umka@cloudlinux.com>>
> ---
>  fs/ext4/namei.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 0adc6df..bebe698 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2413,6 +2413,7 @@ retry:
>
>   inode->i_op = &ext4_dir_inode_operations.ops;
>   inode->i_fop = &ext4_dir_operations;
> + inode->i_flags |= S_IOPS_WRAPPER;
>   err = ext4_init_new_dir(handle, dir, inode);
>   if (err)
>   goto out_clear_inode;
> --
> 1.8.3.1
>
>
> _______________________________________________
> Devel mailing listDevel@openvz.orghttps://lists.openvz.org/mailman/listinfo/devel
>
>
>
Vladimir Meshkov Oct. 17, 2016, 9:40 a.m.
and the commit exists at
https://src.openvz.org/projects/OVZ/repos/vzkernel/browse/fs/ext4/namei.c?at=refs%2Fheads%2Fbranch-rh7-3.10.0-327.28.2.vz7.17.x-ovz
.
Could it be lost?

On Mon, Oct 17, 2016 at 11:48 AM, Vladimir Meshkov <vmeshkov@cloudlinux.com>
wrote:

> Could you please clarify why we cannot find the commit at
> https://src.openvz.org/projects/OVZ/repos/vzkernel/
> browse/fs/ext4/namei.c?at=refs/heads/branch-rh7-3.10.0-
> 327.36.1.vz7.18.x-ovz ? Thank you.
>
> On Fri, Oct 14, 2016 at 9:23 PM, Maxim Patlasov <mpatlasov@virtuozzo.com>
> wrote:
>
>> Thanks! You may be interested to search devel@openvz.org archives for:
>>
>> Subject: [PATCH rh7] ext4: ext4_mkdir must set S_IOPS_WRAPPER bit
>>
>> Date: Mon, 25 Jul 2016 14:01:16 -0700
>>
>> On 10/14/2016 09:47 AM, Vladimir Meshkov wrote:
>>
>> ext4 supports an extended operations like rename2, but
>> inode isn't correctly marked after mkdir.
>>
>> Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com
>> <https://e.mail.ru/compose?To=umka@cloudlinux.com>>
>> ---
>>  fs/ext4/namei.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>> index 0adc6df..bebe698 100644
>> --- a/fs/ext4/namei.c
>> +++ b/fs/ext4/namei.c
>> @@ -2413,6 +2413,7 @@ retry:
>>
>>   inode->i_op = &ext4_dir_inode_operations.ops;
>>   inode->i_fop = &ext4_dir_operations;
>> + inode->i_flags |= S_IOPS_WRAPPER;
>>   err = ext4_init_new_dir(handle, dir, inode);
>>   if (err)
>>   goto out_clear_inode;
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> Devel mailing listDevel@openvz.orghttps://lists.openvz.org/mailman/listinfo/devel
>>
>>
>>
>
Konstantin Khorenko Oct. 17, 2016, 9:41 a.m.
Hi Vladimir,

On 10/17/2016 11:48 AM, Vladimir Meshkov wrote:
> Could you please clarify why we cannot find the commit at
> https://src.openvz.org/projects/OVZ/repos/vzkernel/browse/fs/ext4/namei.c?at=refs/heads/branch-rh7-3.10.0-327.36.1.vz7.18.x-ovz ? Thank you.

It will appear in the branch vz7.18.x a bit later.

--
Konstantin

>
> On Fri, Oct 14, 2016 at 9:23 PM, Maxim Patlasov <mpatlasov@virtuozzo.com <mailto:mpatlasov@virtuozzo.com>> wrote:
>
>     Thanks! You may be interested to search devel@openvz.org <mailto:devel@openvz.org> archives for:
>
>     Subject: [PATCH rh7] ext4: ext4_mkdir must set S_IOPS_WRAPPER bit
>
>     Date: Mon, 25 Jul 2016 14:01:16 -0700
>
>
>     On 10/14/2016 09:47 AM, Vladimir Meshkov wrote:
>>     ext4 supports an extended operations like rename2, but
>>     inode isn't correctly marked after mkdir.
>>
>>     Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com <https://e.mail.ru/compose?To=umka@cloudlinux.com>>
>>     ---
>>      fs/ext4/namei.c | 1 +
>>      1 file changed, 1 insertion(+)
>>
>>     diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>>     index 0adc6df..bebe698 100644
>>     --- a/fs/ext4/namei.c
>>     +++ b/fs/ext4/namei.c
>>     @@ -2413,6 +2413,7 @@ retry:
>>
>>       inode->i_op = &ext4_dir_inode_operations.ops;
>>       inode->i_fop = &ext4_dir_operations;
>>     + inode->i_flags |= S_IOPS_WRAPPER;
>>       err = ext4_init_new_dir(handle, dir, inode);
>>       if (err)
>>       goto out_clear_inode;
>>     --
>>     1.8.3.1
Vladimir Meshkov Oct. 17, 2016, 9:48 a.m.
Konstantin, thank you!

On Mon, Oct 17, 2016 at 12:41 PM, Konstantin Khorenko <
khorenko@virtuozzo.com> wrote:

> Hi Vladimir,
>
> On 10/17/2016 11:48 AM, Vladimir Meshkov wrote:
>
>> Could you please clarify why we cannot find the commit at
>> https://src.openvz.org/projects/OVZ/repos/vzkernel/browse/
>> fs/ext4/namei.c?at=refs/heads/branch-rh7-3.10.0-327.36.1.vz7.18.x-ovz ?
>> Thank you.
>>
>
> It will appear in the branch vz7.18.x a bit later.
>
> --
> Konstantin
>
>
>> On Fri, Oct 14, 2016 at 9:23 PM, Maxim Patlasov <mpatlasov@virtuozzo.com
>> <mailto:mpatlasov@virtuozzo.com>> wrote:
>>
>>     Thanks! You may be interested to search devel@openvz.org <mailto:
>> devel@openvz.org> archives for:
>>
>>     Subject: [PATCH rh7] ext4: ext4_mkdir must set S_IOPS_WRAPPER bit
>>
>>     Date: Mon, 25 Jul 2016 14:01:16 -0700
>>
>>
>>     On 10/14/2016 09:47 AM, Vladimir Meshkov wrote:
>>
>>>     ext4 supports an extended operations like rename2, but
>>>     inode isn't correctly marked after mkdir.
>>>
>>>     Signed-off-by: Alexey Lyashkov <umka@cloudlinux.com <
>>> https://e.mail.ru/compose?To=umka@cloudlinux.com>>
>>>     ---
>>>      fs/ext4/namei.c | 1 +
>>>      1 file changed, 1 insertion(+)
>>>
>>>     diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>>>     index 0adc6df..bebe698 100644
>>>     --- a/fs/ext4/namei.c
>>>     +++ b/fs/ext4/namei.c
>>>     @@ -2413,6 +2413,7 @@ retry:
>>>
>>>       inode->i_op = &ext4_dir_inode_operations.ops;
>>>       inode->i_fop = &ext4_dir_operations;
>>>     + inode->i_flags |= S_IOPS_WRAPPER;
>>>       err = ext4_init_new_dir(handle, dir, inode);
>>>       if (err)
>>>       goto out_clear_inode;
>>>     --
>>>     1.8.3.1
>>>
>>