[Devel] tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)

Submitted by Igor Redko on Oct. 25, 2016, 1:29 p.m.


Message ID 1477402199-843263-1-git-send-email-redkoi@virtuozzo.com
State New
Series "tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)"
Headers show

Commit Message

Igor Redko Oct. 25, 2016, 1:29 p.m.
From: Peter Hurley <peter@hurleysoftware.com>

Fix CVE-2016-0723 #PSBM-53939

upstream: 5c17c861a357e9458001f021a7afa7aab9937439
From: Peter Hurley <peter@hurleysoftware.com>

ioctl(TIOCGETD) retrieves the line discipline id directly from the
ldisc because the line discipline id (c_line) in termios is untrustworthy;
userspace may have set termios via ioctl(TCSETS*) without actually
changing the line discipline via ioctl(TIOCSETD).

However, directly accessing the current ldisc via tty->ldisc is
unsafe; the ldisc ptr dereferenced may be stale if the line discipline
is changing via ioctl(TIOCSETD) or hangup.

Wait for the line discipline reference (just like read() or write())
to retrieve the "current" line discipline id.

Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Igor Redko <redkoi@virtuozzo.com>
 drivers/tty/tty_io.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 5aa8b01..6ccee60 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -2599,6 +2599,28 @@  static int tiocsetd(struct tty_struct *tty, int __user *p)
+ *	tiocgetd	-	get line discipline
+ *	@tty: tty device
+ *	@p: pointer to user data
+ *
+ *	Retrieves the line discipline id directly from the ldisc.
+ *
+ *	Locking: waits for ldisc reference (in case the line discipline
+ *		is changing or the tty is being hungup)
+ */
+static int tiocgetd(struct tty_struct *tty, int __user *p)
+	struct tty_ldisc *ld;
+	int ret;
+	ld = tty_ldisc_ref_wait(tty);
+	ret = put_user(ld->ops->num, p);
+	tty_ldisc_deref(ld);
+	return ret;
  *	send_break	-	performed time break
  *	@tty: device to break on
  *	@duration: timeout in mS
@@ -2812,7 +2834,7 @@  long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case TIOCGSID:
 		return tiocgsid(tty, real_tty, p);
 	case TIOCGETD:
-		return put_user(tty->ldisc->ops->num, (int __user *)p);
+		return tiocgetd(tty, p);
 	case TIOCSETD:
 		return tiocsetd(tty, p);