zdtm: cleanup fifo_loop.test-0*

Submitted by Andrei Vagin on Nov. 5, 2016, 5:56 a.m.

Details

Message ID 1478325392-10935-1-git-send-email-avagin@openvz.org
State Superseded
Series "zdtm: cleanup fifo_loop.test-0*"
Headers show

Commit Message

Andrei Vagin Nov. 5, 2016, 5:56 a.m.
From: Andrei Vagin <avagin@virtuozzo.com>

06:46:44.191:    24: ERR: fifo_loop.c:52: can't make fifo "fifo_loop.test-00" (errno = 17 (File exists))

Reported-by: Mr Jenkins
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
---
 test/zdtm/transition/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/test/zdtm/transition/Makefile b/test/zdtm/transition/Makefile
index 7ddb238..8e82070 100644
--- a/test/zdtm/transition/Makefile
+++ b/test/zdtm/transition/Makefile
@@ -102,7 +102,7 @@  cleandep:	clean
 	$(RM) -f $(DEP)
 
 %.cleanout: %
-	$(Q) $(RM) -f -r $<.pid* $<.out* $<.test chew_$<.test*
+	$(Q) $(RM) -f -r $<.pid* $<.out* $<.test* chew_$<.test*
 
 cleanout:
 	$(RM) -f *.pid *.out* *.test chew*

Comments

Pavel Emelianov Nov. 7, 2016, 7:03 p.m.
Applied
Adrian Reber Nov. 9, 2016, 3:49 p.m.
On Mon, Nov 07, 2016 at 10:03:29PM +0300, Pavel Emelyanov wrote:
> Applied 

I have following which I wanted to submit:

$ cat zdtm/transition/fifo_loop.hook
#!/bin/bash

[ "$1" == "--clean" ] || exit 0

rm -f zdtm/transition/fifo_loop.test-0[0-3]

Would that be accepted?

		Adrian
Andrey Vagin Nov. 9, 2016, 9:20 p.m.
On Wed, Nov 09, 2016 at 04:49:14PM +0100, Adrian Reber wrote:
> On Mon, Nov 07, 2016 at 10:03:29PM +0300, Pavel Emelyanov wrote:
> > Applied 
> 
> I have following which I wanted to submit:
> 
> $ cat zdtm/transition/fifo_loop.hook
> #!/bin/bash
> 
> [ "$1" == "--clean" ] || exit 0
> 
> rm -f zdtm/transition/fifo_loop.test-0[0-3]
> 
> Would that be accepted?

Why we can't use make fifo_loop.cleanout?
> 
> 		Adrian
Adrian Reber Nov. 10, 2016, 7:42 a.m.
On Wed, Nov 09, 2016 at 01:20:57PM -0800, Andrei Vagin wrote:
> On Wed, Nov 09, 2016 at 04:49:14PM +0100, Adrian Reber wrote:
> > On Mon, Nov 07, 2016 at 10:03:29PM +0300, Pavel Emelyanov wrote:
> > > Applied 
> > 
> > I have following which I wanted to submit:
> > 
> > $ cat zdtm/transition/fifo_loop.hook
> > #!/bin/bash
> > 
> > [ "$1" == "--clean" ] || exit 0
> > 
> > rm -f zdtm/transition/fifo_loop.test-0[0-3]
> > 
> > Would that be accepted?
> 
> Why we can't use make fifo_loop.cleanout?

That works much better. You are right. I was not aware of that
functionality.

		Adrian