[Devel,rh7,3/3] net: ip, raw_diag -- Use jump for exiting from nested loop

Submitted by Kirill Gorkunov on Nov. 14, 2016, 10:21 p.m.

Details

Message ID 20161114222118.GF17655@uranus
State New
Series "ipv6: add IPV6_HDRINCL option for raw sockets"
Headers show

Commit Message

Kirill Gorkunov Nov. 14, 2016, 10:21 p.m.
net-next: 9999370faed945be2913cd34aa24e84317a0ceda

I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.

CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Ahern <dsa@cumulusnetworks.com>
CC: Andrey Vagin <avagin@openvz.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Cyrill Gorcunov <gorcunov@virtuozzo.com>
---
 net/ipv4/raw_diag.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

Index: linux-pcs7.git/net/ipv4/raw_diag.c
===================================================================
--- linux-pcs7.git.orig/net/ipv4/raw_diag.c
+++ linux-pcs7.git/net/ipv4/raw_diag.c
@@ -79,10 +79,11 @@  static struct sock *raw_sock_get(struct
 				 * hashinfo->lock here.
 				 */
 				sock_hold(sk);
-				break;
+				goto out_unlock;
 			}
 		}
 	}
+out_unlock:
 	read_unlock(&hashinfo->lock);
 
 	return sk ? sk : ERR_PTR(-ENOENT);