[2/2] test: fix conntracks test

Submitted by Vitaly Ostrosablin on Jan. 10, 2017, 12:17 p.m.

Details

Message ID 20170110121701.5208-2-vostrosablin@virtuozzo.com
State Superseded
Series "Series without cover letter"
Headers show

Commit Message

Vitaly Ostrosablin Jan. 10, 2017, 12:17 p.m.
In some old distros -m state doesn't work correctly and test fails
because test output diverges from expected results. Here we replace
obsoleted -m state with -m conntrack.
---
 test/zdtm/static/conntracks | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/test/zdtm/static/conntracks b/test/zdtm/static/conntracks
index f2819582..a30e0e26 100755
--- a/test/zdtm/static/conntracks
+++ b/test/zdtm/static/conntracks
@@ -29,7 +29,7 @@  do_start()
 
 	do_or_fail "can't install a state match" \
 		iptables -A INPUT \
-		-m state --state RELATED,ESTABLISHED -j ACCEPT
+		-m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
 
 	do_or_fail "can't list the loaded iptables" \
 		iptables -L \> "$statefile"

Comments

Cyrill Gorcunov Jan. 10, 2017, 12:42 p.m.
On Tue, Jan 10, 2017 at 03:17:01PM +0300, Vitaly Ostrosablin wrote:
> In some old distros -m state doesn't work correctly and test fails
> because test output diverges from expected results. Here we replace
> obsoleted -m state with -m conntrack.

You forgot SOB line. Please don't forget next time you send patches.

Signed-off-by: Vitaly Ostrosablin <vostrosablin@virtuozzo.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>