[Devel,rh7,06/11] ms/cred: Reject inodes with invalid ids in set_create_file_as()

Submitted by Konstantin Khorenko on June 22, 2017, 2:47 p.m.


Message ID 1498142878-2222-7-git-send-email-khorenko@virtuozzo.com
State New
Series "Revert "ms/cred: Reject inodes with invalid ids in set_create_file_as()""
Headers show

Commit Message

Konstantin Khorenko June 22, 2017, 2:47 p.m.
From: Seth Forshee <seth.forshee@canonical.com>

Using INVALID_[UG]ID for the LSM file creation context doesn't
make sense, so return an error if the inode passed to
set_create_file_as() has an invalid id.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
(cherry picked from commit 5f65e5ca286126a60f62c8421b77c2018a482b8a)


Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
 kernel/cred.c | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/kernel/cred.c b/kernel/cred.c
index eb7c547..f6bd635 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -682,6 +682,8 @@  EXPORT_SYMBOL(set_security_override_from_ctx);
 int set_create_files_as(struct cred *new, struct inode *inode)
+	if (!uid_valid(inode->i_uid) || !gid_valid(inode->i_gid))
+		return -EINVAL;
 	new->fsuid = inode->i_uid;
 	new->fsgid = inode->i_gid;
 	return security_kernel_create_files_as(new, inode);