test: grow_map -- Mark as noauto

Submitted by Cyrill Gorcunov on June 27, 2017, 6:58 a.m.

Details

Message ID 1498546680-19141-1-git-send-email-gorcunov@openvz.org
State New
Series "test: grow_map -- Mark as noauto"
Headers show

Commit Message

Cyrill Gorcunov June 27, 2017, 6:58 a.m.
As requested by Andrew.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
 test/zdtm/static/grow_map.desc   | 1 +
 test/zdtm/static/grow_map02.desc | 1 +
 test/zdtm/static/grow_map03.desc | 1 +
 3 files changed, 3 insertions(+)
 create mode 100644 test/zdtm/static/grow_map.desc
 create mode 100644 test/zdtm/static/grow_map02.desc
 create mode 100644 test/zdtm/static/grow_map03.desc

Patch hide | download patch | download mbox

diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
new file mode 100644
index 000000000000..95c58b4018b3
--- /dev/null
+++ b/test/zdtm/static/grow_map.desc
@@ -0,0 +1 @@ 
+{'flags': 'noauto'}
diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
new file mode 100644
index 000000000000..95c58b4018b3
--- /dev/null
+++ b/test/zdtm/static/grow_map02.desc
@@ -0,0 +1 @@ 
+{'flags': 'noauto'}
diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
new file mode 100644
index 000000000000..95c58b4018b3
--- /dev/null
+++ b/test/zdtm/static/grow_map03.desc
@@ -0,0 +1 @@ 
+{'flags': 'noauto'}

Comments

Pavel Emelianov June 27, 2017, 11:50 a.m.
On 06/27/2017 09:58 AM, Cyrill Gorcunov wrote:
> As requested by Andrew.

Adnrey? What's the reason?

> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>  test/zdtm/static/grow_map.desc   | 1 +
>  test/zdtm/static/grow_map02.desc | 1 +
>  test/zdtm/static/grow_map03.desc | 1 +
>  3 files changed, 3 insertions(+)
>  create mode 100644 test/zdtm/static/grow_map.desc
>  create mode 100644 test/zdtm/static/grow_map02.desc
>  create mode 100644 test/zdtm/static/grow_map03.desc
> 
> diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
> diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map02.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
> diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map03.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
>
Cyrill Gorcunov June 27, 2017, 12:06 p.m.
On Tue, Jun 27, 2017 at 02:50:47PM +0300, Pavel Emelyanov wrote:
> On 06/27/2017 09:58 AM, Cyrill Gorcunov wrote:
> > As requested by Andrew.
> 
> Adnrey? What's the reason?

Most likely they will be failing on vanilla kernel, until (if only)
kernel will be fixed at all.
Vasily Averin June 27, 2017, 12:09 p.m.
Pavel, 
grow_maps fails on kernels with Stackguard fix.

http://marc.info/?l=linux-kernel&m=149814139409086&w=2
From Oleg Nesterov:
"With the recent kernel changes criu should never look outside of start-end
region reported by /proc/maps; and restore doesn't even need to know if a
GROWSDOWN region will actually grow or not, because (iiuc) you do not need
to auto-grow the stack vma during restore, criu re-creates the whole vma
with the same length using MAP_FIXED and it should never write below the
addr returned by mmap(MAP_FIXED)"

On 2017-06-27 14:50, Pavel Emelyanov wrote:
> On 06/27/2017 09:58 AM, Cyrill Gorcunov wrote:
>> As requested by Andrew.
> 
> Adnrey? What's the reason?
> 
>> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>> ---
>>  test/zdtm/static/grow_map.desc   | 1 +
>>  test/zdtm/static/grow_map02.desc | 1 +
>>  test/zdtm/static/grow_map03.desc | 1 +
>>  3 files changed, 3 insertions(+)
>>  create mode 100644 test/zdtm/static/grow_map.desc
>>  create mode 100644 test/zdtm/static/grow_map02.desc
>>  create mode 100644 test/zdtm/static/grow_map03.desc
>>
>> diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
>> new file mode 100644
>> index 000000000000..95c58b4018b3
>> --- /dev/null
>> +++ b/test/zdtm/static/grow_map.desc
>> @@ -0,0 +1 @@
>> +{'flags': 'noauto'}
>> diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
>> new file mode 100644
>> index 000000000000..95c58b4018b3
>> --- /dev/null
>> +++ b/test/zdtm/static/grow_map02.desc
>> @@ -0,0 +1 @@
>> +{'flags': 'noauto'}
>> diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
>> new file mode 100644
>> index 000000000000..95c58b4018b3
>> --- /dev/null
>> +++ b/test/zdtm/static/grow_map03.desc
>> @@ -0,0 +1 @@
>> +{'flags': 'noauto'}
>>
> 
> _______________________________________________
> CRIU mailing list
> CRIU@openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
>
Pavel Emelianov June 27, 2017, 12:22 p.m.
On 06/27/2017 03:09 PM, Vasily Averin wrote:
> Pavel, 
> grow_maps fails on kernels with Stackguard fix.
> 
> http://marc.info/?l=linux-kernel&m=149814139409086&w=2
>>From Oleg Nesterov:
> "With the recent kernel changes criu should never look outside of start-end
> region reported by /proc/maps; and restore doesn't even need to know if a
> GROWSDOWN region will actually grow or not, because (iiuc) you do not need
> to auto-grow the stack vma during restore, criu re-creates the whole vma
> with the same length using MAP_FIXED and it should never write below the
> addr returned by mmap(MAP_FIXED)"

OK. Plz, add it to commit message :)

> On 2017-06-27 14:50, Pavel Emelyanov wrote:
>> On 06/27/2017 09:58 AM, Cyrill Gorcunov wrote:
>>> As requested by Andrew.
>>
>> Adnrey? What's the reason?
>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>>> ---
>>>  test/zdtm/static/grow_map.desc   | 1 +
>>>  test/zdtm/static/grow_map02.desc | 1 +
>>>  test/zdtm/static/grow_map03.desc | 1 +
>>>  3 files changed, 3 insertions(+)
>>>  create mode 100644 test/zdtm/static/grow_map.desc
>>>  create mode 100644 test/zdtm/static/grow_map02.desc
>>>  create mode 100644 test/zdtm/static/grow_map03.desc
>>>
>>> diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>> diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map02.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>> diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
>>> new file mode 100644
>>> index 000000000000..95c58b4018b3
>>> --- /dev/null
>>> +++ b/test/zdtm/static/grow_map03.desc
>>> @@ -0,0 +1 @@
>>> +{'flags': 'noauto'}
>>>
>>
>> _______________________________________________
>> CRIU mailing list
>> CRIU@openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
>>
> .
>
Cyrill Gorcunov June 27, 2017, 12:28 p.m.
On Tue, Jun 27, 2017 at 03:22:01PM +0300, Pavel Emelyanov wrote:
> On 06/27/2017 03:09 PM, Vasily Averin wrote:
> > Pavel, 
> > grow_maps fails on kernels with Stackguard fix.
> > 
> > http://marc.info/?l=linux-kernel&m=149814139409086&w=2
> >>From Oleg Nesterov:
> > "With the recent kernel changes criu should never look outside of start-end
> > region reported by /proc/maps; and restore doesn't even need to know if a
> > GROWSDOWN region will actually grow or not, because (iiuc) you do not need
> > to auto-grow the stack vma during restore, criu re-creates the whole vma
> > with the same length using MAP_FIXED and it should never write below the
> > addr returned by mmap(MAP_FIXED)"
> 
> OK. Plz, add it to commit message :)

Just merge it on committing.
Andrey Vagin June 27, 2017, 6:20 p.m.
Applied
On Tue, Jun 27, 2017 at 09:58:00AM +0300, Cyrill Gorcunov wrote:
> As requested by Andrew.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>  test/zdtm/static/grow_map.desc   | 1 +
>  test/zdtm/static/grow_map02.desc | 1 +
>  test/zdtm/static/grow_map03.desc | 1 +
>  3 files changed, 3 insertions(+)
>  create mode 100644 test/zdtm/static/grow_map.desc
>  create mode 100644 test/zdtm/static/grow_map02.desc
>  create mode 100644 test/zdtm/static/grow_map03.desc
> 
> diff --git a/test/zdtm/static/grow_map.desc b/test/zdtm/static/grow_map.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
> diff --git a/test/zdtm/static/grow_map02.desc b/test/zdtm/static/grow_map02.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map02.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
> diff --git a/test/zdtm/static/grow_map03.desc b/test/zdtm/static/grow_map03.desc
> new file mode 100644
> index 000000000000..95c58b4018b3
> --- /dev/null
> +++ b/test/zdtm/static/grow_map03.desc
> @@ -0,0 +1 @@
> +{'flags': 'noauto'}
> -- 
> 2.7.5
>