Message ID | 20180124121503.26930-9-aryabinin@virtuozzo.com |
---|---|
State | New |
Series | "compaction related stable backports." |
Headers | show
Delivered-To: criupatchwork@gmail.com Received: from gmail-imap.l.google.com [64.233.165.109] by patchwork.criu.org with IMAP (fetchmail-6.3.26) for <root@localhost> (single-drop); Wed, 24 Jan 2018 13:17:37 +0100 (CET) Received: by 10.100.182.129 with SMTP id t1csp643234pjb; Wed, 24 Jan 2018 04:17:22 -0800 (PST) X-Google-Smtp-Source: AH8x224xo2/fYtXFHwKcwBFcx5P7KmeikR0PJETuC9XQMXJS/bWClSEbpAIAHIX4tePWE+QNycec X-Received: by 10.98.234.4 with SMTP id t4mr12953711pfh.74.1516796242564; Wed, 24 Jan 2018 04:17:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516796242; cv=none; d=google.com; s=arc-20160816; b=KpxlODwu7sD1lc3CZW8BRhYx/i9eZN1RT3eKCDp/tNM7cFQXfrGVe/Rktm6uQw2fWZ VYdAGVdQw4OIFYikU7fXLksALTJUyjoYxMGThEmPvYDnGlua+GisTtp06cA1+iqldA4F kPES95QfWUeINqDSR5NYzOKwlsbTLs/4wUD1mui31nmSg2ga6rc+DITRbw0psKTjXCJx 925YrK2A9JFYVdN2hVsFg0qu8w7ITFQnsb4tDK3lvOe/TimFPjZITIss9ixTtQewqoQc 0fZsk1J10D6HHo1ymWwDqw541BV8JsO2P7t/L8thSp2G1OYWpKpKZ4vBF93FonmyyGIe 9tqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:to:from:arc-authentication-results; bh=WSjmY6KbXnXCvERopSs5EPWyWXQXzfoRSyVQzPK8ryw=; b=ngcZrGCNeEsgZR/ZMAhFr67hbJYydsMcBVS7UrSh4dJIO4stLEvCzrMon19h5PztU7 v/6Y3y7IB50OYTxaj7m87Yo0FcW6TBoNix4XKfERayyeNEcDzMUeipxhaV0pFic93l3V G4sysm8ENK9ra0E3rrc5oSuActlg26xwmlqZyYeT+Yz8uM+o452k30Xz54VWot+gsBmt I0U8d0EfdlWKIcVddGaf9EZB4awqXd9Y+myDAuJKgI6AANDElL+Wypx5T6rmfUJqMx0T 3qWF1QqUazBQE2R+SS9uhAEpCp+SCu+bC/3fsLruET85HjqhlGTHAn7qOb5OxcWedRKZ 59ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 195.214.232.140 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: <devel-bounces@openvz.org> Received: from mail.openvz.org (mail.openvz.org. [195.214.232.140]) by mx.google.com with ESMTPS id 34-v6si122719plc.650.2018.01.24.04.17.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 04:17:22 -0800 (PST) Received-SPF: pass (google.com: domain of devel-bounces@openvz.org designates 195.214.232.140 as permitted sender) client-ip=195.214.232.140; Authentication-Results: mx.google.com; spf=pass (google.com: domain of devel-bounces@openvz.org designates 195.214.232.140 as permitted sender) smtp.mailfrom=devel-bounces@openvz.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id w0OCFGoD023776; Wed, 24 Jan 2018 15:15:16 +0300 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp0120.outbound.protection.outlook.com [213.199.154.120]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id w0OCFERK023714 for <devel@openvz.org>; Wed, 24 Jan 2018 15:15:14 +0300 Authentication-Results: openvz.org; dkim=none (message not signed) header.d=none; openvz.org; dmarc=none action=none header.from=virtuozzo.com; Received: from localhost.sw.ru (195.214.232.6) by DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Wed, 24 Jan 2018 12:15:04 +0000 From: Andrey Ryabinin <aryabinin@virtuozzo.com> To: devel@openvz.org Date: Wed, 24 Jan 2018 15:14:46 +0300 Message-Id: <20180124121503.26930-9-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180124121503.26930-1-aryabinin@virtuozzo.com> References: <20180124121503.26930-1-aryabinin@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0102CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:7:14::31) To DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 624ed59f-a3af-4a2d-7272-08d563241a09 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR08MB2822; X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2822; 3:Hc0JTWQM0j1BF5dlbNT4JUICkZkseRistQqQOijivI1Y+oB7G1NZh0ac1sxKNmbldo06VrJGzMXlkgSGevGaYMyVjOBgKY+k046JKY6T3i5rTCV+YXZHUioYW7F12IcbKVmYXYnBr8CgAwytLDHqNyTpHJaC4PM9w+Khm6Jov+pHnVXfgxTGJCaBLfAVLQ7pqdZ55ZrpeJYc6k+HNU+n49MCI1PkunEEQxPU7ltZjSWve+W5BLD9bkRo0ltV19Bw; 25:hWg/tmfB1nB4maseTaefSI660d99TBIzFovZcBi57byeoGOTXTlEOSwuuby5/QLevvX6/JVctgA0Ao1FFLzSgnpD+Tllz5zdTxagi3Gv7LoNUKyT/NT7WyTq63Cj4oMvKeX/wQvILyCJoXm7RhuCOaePw5Rl9wacJ5TMXKIGDZjpqSucxuKIcMHB6QVtBU/qeTs3AmwLbleKbWkE6sK4tbmdUPY9xs3oaSgnsCaZWLubGWoxb2ZqCDKtncluV6dLpdfAVWY6Ingu1WsT09Ft4OXz9tdoYEI6D9wlaLxEZ3NBujZqgmW/SEhGuJI46d1q95wHJFnmE3Z45sWyubRsvQ==; 31:b0f0d1kphr7S2rGXD1kLNb76m4JldYIskSBmD97nZY1mqo4tkoLu+zuv3j4DtyuXc8st5HHopZxY5yglW7EOxhbacOKnbgBLoyNoXnTdqesq6CPFdFYMI2qMYuhzKK20mPpB7muNp4f4YOWDuZ/HyQ4t57BIofjGn0/TqmZvq27hb0Zy/CpcgZdGxz1nvZJifYvNI6ONcFjWbkem4LOSiCmZktFtW7H9uDrfk8V4wtI= X-MS-TrafficTypeDiagnostic: DB6PR08MB2822: X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2822; 20:u/XM5mQTXF35N4rmxahELKz12V9DkdnHe8EU3Ze9n8j/VdGpDnFGeJvQGfFwwLy/iaESt7kzxShgYgejdMxXgP/jtdng4h3ULCWP1LQHFQaQhGSf8TOW4qreLnkIf29lHUIM6vyUSVCEVh5uEvG1j1x7BahuAAe88eqpiW6E7IGEaULtQ9nUDI8rVHRCDkqEyk64uw8/tkun8VesRccStB4o1OKpqx4IqDWqXfNLRaI/cZdbcOiq345VT7y7xaUbZ1w8VltzRrk6yEE6o4i++PieRRTAs4lLMY6KnXJhdgrk+dfcrQKHzVK4HBqeSvp3imtDI3EUmYTmIHhD8pE6S5cSCLY8PzgFSA/zilKTfLDcRx0CsMtfDHt0uwHfIPBkglfeMY0ovYBaHwc44zjKzZdxKlH2HhS1l6s756x3xEE=; 4:+rhPDbpvNSXs6Q+az7djh1wtDXpBBVzPjvE1xCTsLnuzhNeFbn0pDUtxX42/QFDXgbi9gXWhUDnPVHVnZDWluUdk33VwzF4FUmLbkvrf+gd3RkYdcmX8RcLjCkyaVSOuzWMYT5bDml3YUB79a6cjIF5l1iV/0SkhwJR0OKnAi5VhwFsyfoX1mU4z4I91eAzwxbJVPRYdQHqegfuq0IlYAG6pv2b3QyyRNedu4I5PmgiDxs9jKT2BTv/aVYJWkW5XjY67XM0z6ww158foha/dpA==; 23:1KRviHtZBNh508ZU08WRa8b4dXE2gWnYXMGAcaZB/JD492U9vDytQLvuXUAsRHAEoYcmk50Zbxqew8HojkEFTy0+4QGj4gCCgvwgkIsoZIkRUL2+yA6ciBWvA/GFO/+ygjO7JStCQfuAceNJFG96Ew== X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(9101524173)(2401047)(8121501046)(3002001)(3231023)(2400081)(944501161)(93006095)(93001095)(10201501046)(201708071742011); SRVR:DB6PR08MB2822; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2822; X-Forefront-Antispam-Report: SFV:SKI; SFS:; DIR:INB; SFP:; SCL:-1; SRVR:DB6PR08MB2822; H:localhost.sw.ru; FPR:; SPF:None; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2822; 6:0/zJMgd+O3La6r+IZSS9QNFOqJEIK/pDbVd7vA4J5Zso2ds2RwwcME/eS3OhnjvIrTbu0bOLtwMnnzntmPZTMlYN2RCXvhpUx2onGb6uVuPxrfbZICtKGLgr5Tcd2DNkCdcUacv45t7gpEoW9VR9VNjwp5ssahH1nRmQJgXQRCiPP+OIzftvwWP1Z+zSseVlAUjT9L7ZpoMSc4n/HxwtmL7QSep8/n67itiZVRqXNTndiaevNx6lB/3VrFsABCG6F+Oon4GlZaa1NHqpWrNiiHMGNnf9y+hCu6ZeFxUKlCbnciQFEuJUqq4fd0TvSbOaHmqd39Q/80Il4SaCpuhOlZHrXz1+0w1xfHFdYb0Nj4E=; 5:WhFuIAh3+5oSKUtwcqo6120nhn7fbNFNn4VPqUVY6Bh73rpCa9MsH8qQw2iDO/yW70jhZEm99tABRuclWd/ManKrVeZcCeHu5VCBTo8BfEvVuVz8exKLyuXLNR0kJGtpvyClA5dsL25l8O9MfEvetuwBwhoeB6s+LC95+2E90YE=; 24:mEW7GSZLysVooXLvEes2+/r1xhQAf/s7KL184SB5pJ8NZ8OdzLgSzuFoCoQYJAi7D9PK/JxT9c2kQLSAsYWjQRfJ134YVS7Qpg7iZ/Jx1RM=; 7:4sBkCbX2Q8YA5AbXyb3tDFuadkZ+9Q2/le+eO01nXUBcb8IEMddA7m1/+RPM63PR/GCvY8HaFi8pmFj8Vvv1XU7elj7a84eS3mnHwx/xpmxObNH3dz+LkLH2JOOiIp/ab4j0SXvo+e78kOjGsXL/gem0wLBqfTUZmxGLQ/p0fM3N0mlzwNyzJVusuxYEKWzyHGXuP/Y4if+X37Fr/MHcee+Gu86T9O6Zf3BauzZks0L5h4HQ8BToGnzRfG1oq0Ty SpamDiagnosticOutput: 1:0 X-Microsoft-Exchange-Diagnostics: 1; DB6PR08MB2822; 20:cX4dMVM64GWpPY71ap9l69jXPyfzR2+DiJ3T6nefzF94hqkUM25wQs9H+bSxLjRZtMJ8yNhvo/lZYSvxpVTE2D2DBe35WeULt1Xfm4OyIdOgui+sxraMAM/QVJiaNyR8FjHwuYPrTUrw8Dd4yAzJfEOU5fJElZLGBwKKjZJhIhI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2018 12:15:04.5686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 624ed59f-a3af-4a2d-7272-08d563241a09 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822 X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 195.214.232.6 X-MS-Exchange-CrossPremises-AuthSource: DB6PR08MB2822.eurprd08.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-TransportTrafficSubType: X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:SKI; SKIP:0; X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: DB6PR08MB2822.eurprd08.prod.outlook.com Subject: [Devel] [PATCH rh7 08/25] ms/mm/compaction: do not call suitable_migration_target() on every page X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development <devel.openvz.org> List-Unsubscribe: <https://lists.openvz.org/mailman/options/devel>, <mailto:devel-request@openvz.org?subject=unsubscribe> List-Archive: <http://lists.openvz.org/pipermail/devel/> List-Post: <mailto:devel@openvz.org> List-Help: <mailto:devel-request@openvz.org?subject=help> List-Subscribe: <https://lists.openvz.org/mailman/listinfo/devel>, <mailto:devel-request@openvz.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org |
diff --git a/mm/compaction.c b/mm/compaction.c index 1faade458d38..c29883fe146d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -247,6 +247,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, struct page *cursor, *valid_page = NULL; unsigned long flags; bool locked = false; + bool checked_pageblock = false; cursor = pfn_to_page(blockpfn); @@ -278,8 +279,16 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, break; /* Recheck this is a suitable migration target under lock */ - if (!strict && !suitable_migration_target(page)) - break; + if (!strict && !checked_pageblock) { + /* + * We need to check suitability of pageblock only once + * and this isolate_freepages_block() is called with + * pageblock range, so just check once is sufficient. + */ + checked_pageblock = true; + if (!suitable_migration_target(page)) + break; + } /* Recheck this is a buddy page under lock */ if (!PageBuddy(page))