Message ID | 20160706134820.15384-2-dsafonov@virtuozzo.com |
---|---|
State | Superseded |
Commit | acb83b3172cca8c4bc8391dc24f28023e0aefd1d |
Headers | show
Delivered-To: criupatchwork@gmail.com Received: from gmail-imap.l.google.com [74.125.199.108] by zdtm.openvz.org with IMAP (fetchmail-6.3.26) for <root@localhost> (single-drop); Wed, 06 Jul 2016 15:49:56 +0200 (CEST) Received: by 10.37.4.151 with SMTP id 145csp835016ybe; Wed, 6 Jul 2016 06:49:52 -0700 (PDT) X-Received: by 10.98.79.17 with SMTP id d17mr41987955pfb.127.1467812991865; Wed, 06 Jul 2016 06:49:51 -0700 (PDT) Return-Path: <criu-bounces@openvz.org> Received: from mail.openvz.org (mail.openvz.org. [199.115.104.192]) by mx.google.com with ESMTPS id c1si4071001paz.112.2016.07.06.06.49.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 06:49:51 -0700 (PDT) Received-SPF: pass (google.com: domain of criu-bounces@openvz.org designates 199.115.104.192 as permitted sender) client-ip=199.115.104.192; Authentication-Results: mx.google.com; spf=pass (google.com: domain of criu-bounces@openvz.org designates 199.115.104.192 as permitted sender) smtp.mailfrom=criu-bounces@openvz.org; dmarc=fail (p=NONE dis=NONE) header.from=virtuozzo.com Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id u66DnYN5016635; Wed, 6 Jul 2016 06:49:34 -0700 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp0241.outbound.protection.outlook.com [213.199.154.241]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id u66DnVpL016614 for <criu@openvz.org>; Wed, 6 Jul 2016 06:49:32 -0700 Authentication-Results: openvz.org; dkim=none (message not signed) header.d=none; openvz.org; dmarc=none action=none header.from=virtuozzo.com; Received: from dsafonov.sw.ru (195.214.232.10) by VI1PR0801MB1744.eurprd08.prod.outlook.com (10.168.67.22) with Microsoft SMTP Server (TLS) id 15.1.528.16; Wed, 6 Jul 2016 13:49:31 +0000 From: Dmitry Safonov <dsafonov@virtuozzo.com> To: <criu@openvz.org> Date: Wed, 6 Jul 2016 16:48:17 +0300 Message-ID: <20160706134820.15384-2-dsafonov@virtuozzo.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160706134820.15384-1-dsafonov@virtuozzo.com> References: <20160706134820.15384-1-dsafonov@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM3PR08CA0015.eurprd08.prod.outlook.com (10.160.207.153) To VI1PR0801MB1744.eurprd08.prod.outlook.com (10.168.67.22) X-MS-Office365-Filtering-Correlation-Id: a55e14d4-b85f-4e5c-fb28-08d3a5a45b61 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1744; 2:1JmT93cqnfvZAhv1P+TivTxuK2BEESk2/PicPGJbjTaIdgVFOtdBMThK4RHiFpXC74jMy+ltq9EpjyLx4015o7Aw2OeztE8VrV7W4k3JFKtsqtCi7Ewb9sREqpFUuDrsFC/prFc8tjFOVnusAnj8Qm8RNqFn3amH6GTYZRMVcwJ/p2VL3VR18MStGnYc7CSI; 3:SHpKkvTd4R5Kxi7nrmhw71vqXPL/Uhd72egA7TqQu1r80KP2h1FAm83NvxP3iORiJTTZPBhQHsyiOB7VTwFG4vwvyuuDjuQKwhrDrclV+ZMRATFcwo9dwgzbSWTZcQx6; 25:kvkfB3bbCW7AGcfKClIZwhXYOkUp0guJUlOOzxkEB9FCeEp0vIJo3NLkl/GD2zyS/kpTIEsEtEushkW9CN3mVwmlkpPEERdowoNizEF+RIIQqPKEjF0Nr4J8qtCpeKrs2/uTNMWgyxye9XUX+g0EpezNqD9rn2eC2/kfNnhUjwn6le/Lu0lvSSoC75b0ekAlmFIv6AaDgGEmLYqqaPo571wMvgF/4NDAOD7bIK9aJOg359mjTZbnKSSt6UWlfeBG45PTM8zRzjxRtj1Ck4ZrrwOXTaH7IdpU5Q2XPG7Zs7qsUDYqblLQzvDjqCrMAel402j5j5kVrFdrkcChGPwsM2DakjEfetmwOQtJdYkgdGYpIUSw5c0gXyM8vRQdzK7SdpYUObX9DJJZc9v1uwe59g3kelmLxpQiFuWNUunkjQY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1744; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1744; 31:EP/cerHqcM+TOknVATpsDa3C5njaFPPzWFJybM/in2cjbfC2wps1TYI4QnEVSVUaNqPnDLDNLxtgLqYIHOvo1NeQmqKNNNAq7zJYKOiBMVoscK7WyhY3giE97OdApN1CFXnGsEPR8gMQtmyY9Enui3NgIjZbuPa5wSCiyC5+Wwclc1HH+o3u3W0vg4t29v1JJk4BxzenX1a3Pib//PTJKw==; 4:e/eZLP9wkLd0vusFB1UNNLa/S+Ie/SIdESKMjiXSLwT/9MPj1HilrVanUlv7m4r4GXN8lNmMZbij018dzo76LpXikkeX5lDxUitmjHEVa81eRzxol+EHmZ4fww8D+hXBXU0KHuzdyF0F9Xr8YJM5O4cgKoL6RbQHcVgHfGqcZEZ7qA4Uf22Q3uBdwh1e51FcoaykugIRHbKXXdug+Uum7gSgWBhmkbSJblxZPFf+eJO3fo8BKNyOWDYFhWsPBpSXRTRNfKNwckvnLqLRyKUxpB6ZTzWN1IKKhMQrRh2LZiXi9viWRfMxyuf1je59eP/T0SP2htPt+VRV69RXWDiHNc8bspA/Y7ENoY5ATDgOjsRxogKxFFZJZXBiFkG6Brum; 23:6K6URjh+XV/9cM61kYWS22tqKv2Ighw4fM/iLJPY3Mf6WUJnR+PoEbYp4SQeRdaJZ8IHUZcLUqSG7kUSJkNNzMu+bToLuHHrhwuM9u+W0SlkSepFGeEa0qX+aTeI5cHnw+fPfkWzKIQASpn737w2f2Pe/WrWZzPvB9I+jYSltnCE/55gh0xvRo6c6vIt8V32 X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(9101524098)(601004)(2401047)(8121501046)(3002001)(10201501046); SRVR:VI1PR0801MB1744; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0801MB1744; X-Forefront-Antispam-Report: SFV:SKI; SFS:; DIR:INB; SFP:; SCL:-1; SRVR:VI1PR0801MB1744; H:dsafonov.sw.ru; FPR:; SPF:None; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1744; 6:UEs63DECSsNb8Wvg3d8RWEfyB/kPWvO/DkX2QLkAAcNlOfrE+TRraOUaFr3USfMRDDOtZFibeyKtv7CJCQyA9qhdleBuJDDvf709RcL3CF05Tg/rlxWHKVhYKOqpKzTS2HGYpPtQ9cFQmjW1vxOfGVmSzd4kWNgmsKtQzTVeEZxlQWSFzYyi/xIMa7jhPOMJCHU6vrlsTo4otQXiU0d6fHZxyv+J+mpm0EVjL0JQ4KPK+VnmO3LN45IpFGv0zVzMeV7G2+8Br1Lwhnziku09+Y954a3VCn4EkcUdScFFEJM=; 5:RjQoujYve2MZvEWtdk83UhbH0f5IK9ASdBv0gqJ7l1DZ/gqRNqmQ2an32uLqm1LnpYAwNJz3Ym0b7e4T/Xq8f5x/Aa0EG7etuu59y5etnjBC/fjjOzC1oIgzhVvtBM5Ma/KkdYR/9af0cbWI3A26Fw==; 24:S7Poytqq8RzxiiqtxOzMIcIVwiGltewGK+opv3zhi6KtKXFMLn4H3cVp/p9wUSxU8Z/OoXwUD29pgXS6b1pMGSV0XumsbmFGHicHwRcQomg=; 7:PCYcp6G/FcL1nWt6zGduDySE/KzjHQnS6D6ILNnmDV9A1f0ck09dSD5BG2h6kYOTbjFmMJZjatBdHaS2Y17ALp06VXpWKCYOjhFtF9q8WnBEp5TcUdOS4biG2p6El//A/FEHPqgioCnSobQpHFvrpy75aeBZWaEAE64Xudq7GaJIITCiN0pf6L6EHwaEiPRhbuyjhVGxCvHt2BfNVBE8ts1SR4ekEOlOX1+PdVz7XIK09rj0ZE2TSzxE9RMVnyak SpamDiagnosticOutput: 1:0 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0801MB1744; 20:XN4s+WWJjdrOftZpE0wVge5RQsoUBhTNEifqZyUmGoCVblZkh5td+GQpCsxaWTrSY01vSP9LxbZoFLfphL2PBy/fX+6mPcbKXtte11htROMdmwCpPOp1uObGNy3c0U1TEudIbVpQvb6bxigvkD658B0ausQvA/X4UsJCgrhJj84= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2016 13:49:31.1485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1744 X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 195.214.232.10 X-MS-Exchange-CrossPremises-AuthSource: VI1PR0801MB1744.eurprd08.prod.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 06 X-MS-Exchange-CrossPremises-AVStamp-Service: 1.0 X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:SKI; SKIP:0; X-MS-Exchange-CrossPremises-Journaled-To-Recipients: log@odin.com X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: VI1PR0801MB1744.eurprd08.prod.outlook.com Cc: Dmitry Safonov <dsafonov@virtuozzo.com> Subject: [CRIU] [PATCH 1/3] x86/ptrace: describe failures from errno X-BeenThere: criu@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: CRIU development <criu.openvz.org> List-Unsubscribe: <https://lists.openvz.org/mailman/options/criu>, <mailto:criu-request@openvz.org?subject=unsubscribe> List-Archive: <http://lists.openvz.org/pipermail/criu/> List-Post: <mailto:criu@openvz.org> List-Help: <mailto:criu-request@openvz.org?subject=help> List-Subscribe: <https://lists.openvz.org/mailman/listinfo/criu>, <mailto:criu-request@openvz.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: criu-bounces@openvz.org Errors-To: criu-bounces@openvz.org |
diff --git a/criu/arch/x86/crtools.c b/criu/arch/x86/crtools.c index d7a6d105cdf5..97dda697c203 100644 --- a/criu/arch/x86/crtools.c +++ b/criu/arch/x86/crtools.c @@ -346,6 +346,11 @@ int ptrace_get_regs(pid_t pid, user_regs_struct_t *regs) iov.iov_len = sizeof(user_regs_struct64); ret = ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov); + if (ret == -1) { + pr_perror("PTRACE_GETREGSET failed"); + return -1; + } + if (iov.iov_len == sizeof(regs->native)) { regs->__is_native = NATIVE_MAGIC; return ret;
ptrace_get_regs correctly returns error code in case of failure, but for debugging reasons let's add error printing in case of PTRACE_GETREGSET failed right after the call to ptrace(). Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com> --- criu/arch/x86/crtools.c | 5 +++++ 1 file changed, 5 insertions(+)