| Message ID | 154028374379.9417.7352325060757318287.stgit@localhost.localdomain |
|---|---|
| State | New |
| Series | "fuse kio: Unexport pcs_ioconn_close() and pcs_ioconn_unregister()" |
| Headers | show |
diff --git a/fs/fuse/kio/pcs/pcs_sock_io.c b/fs/fuse/kio/pcs/pcs_sock_io.c index 04b63b58dad6..ede71c255084 100644 --- a/fs/fuse/kio/pcs/pcs_sock_io.c +++ b/fs/fuse/kio/pcs/pcs_sock_io.c @@ -42,13 +42,13 @@ void sio_push(struct pcs_sockio * sio) //// caseB: kernelspace want to close socket and have to somehow //// notify about this to userspace (NEW API REQUIRED) static void pcs_restore_sockets(struct pcs_ioconn *ioconn); -void pcs_ioconn_unregister(struct pcs_ioconn *ioconn) +static void pcs_ioconn_unregister(struct pcs_ioconn *ioconn) { if (!test_bit(PCS_IOCONN_BF_DEAD, &ioconn->flags)) set_bit(PCS_IOCONN_BF_DEAD, &ioconn->flags); } -void pcs_ioconn_close(struct pcs_ioconn *ioconn) +static void pcs_ioconn_close(struct pcs_ioconn *ioconn) { kernel_sock_shutdown(ioconn->socket, SHUT_RDWR); } diff --git a/fs/fuse/kio/pcs/pcs_sock_io.h b/fs/fuse/kio/pcs/pcs_sock_io.h index 30771170b84c..7795212045c2 100644 --- a/fs/fuse/kio/pcs/pcs_sock_io.h +++ b/fs/fuse/kio/pcs/pcs_sock_io.h @@ -231,9 +231,4 @@ struct bufqueue; */ struct pcs_msg* bufqueue_as_pcs_output_msg(struct bufqueue *bq, u32 size); - -void pcs_ioconn_unregister(struct pcs_ioconn *ioconn); -void pcs_ioconn_close(struct pcs_ioconn *ioconn); - - #endif /* _PCS_SOCK_IO_H_ */
On 23.10.2018 11:35, Kirill Tkhai wrote: > They are used only in the file they are declared. > > Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> Reviewed-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > fs/fuse/kio/pcs/pcs_sock_io.c | 4 ++-- > fs/fuse/kio/pcs/pcs_sock_io.h | 5 ----- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/fs/fuse/kio/pcs/pcs_sock_io.c b/fs/fuse/kio/pcs/pcs_sock_io.c > index 04b63b58dad6..ede71c255084 100644 > --- a/fs/fuse/kio/pcs/pcs_sock_io.c > +++ b/fs/fuse/kio/pcs/pcs_sock_io.c > @@ -42,13 +42,13 @@ void sio_push(struct pcs_sockio * sio) > //// caseB: kernelspace want to close socket and have to somehow > //// notify about this to userspace (NEW API REQUIRED) > static void pcs_restore_sockets(struct pcs_ioconn *ioconn); > -void pcs_ioconn_unregister(struct pcs_ioconn *ioconn) > +static void pcs_ioconn_unregister(struct pcs_ioconn *ioconn) > { > if (!test_bit(PCS_IOCONN_BF_DEAD, &ioconn->flags)) > set_bit(PCS_IOCONN_BF_DEAD, &ioconn->flags); > } > > -void pcs_ioconn_close(struct pcs_ioconn *ioconn) > +static void pcs_ioconn_close(struct pcs_ioconn *ioconn) > { > kernel_sock_shutdown(ioconn->socket, SHUT_RDWR); > } > diff --git a/fs/fuse/kio/pcs/pcs_sock_io.h b/fs/fuse/kio/pcs/pcs_sock_io.h > index 30771170b84c..7795212045c2 100644 > --- a/fs/fuse/kio/pcs/pcs_sock_io.h > +++ b/fs/fuse/kio/pcs/pcs_sock_io.h > @@ -231,9 +231,4 @@ struct bufqueue; > */ > struct pcs_msg* bufqueue_as_pcs_output_msg(struct bufqueue *bq, u32 size); > > - > -void pcs_ioconn_unregister(struct pcs_ioconn *ioconn); > -void pcs_ioconn_close(struct pcs_ioconn *ioconn); > - > - > #endif /* _PCS_SOCK_IO_H_ */ >
They are used only in the file they are declared. Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> --- fs/fuse/kio/pcs/pcs_sock_io.c | 4 ++-- fs/fuse/kio/pcs/pcs_sock_io.h | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-)