[RHEL7,COMMIT] ms/ksm: replace jhash2 with xxhash

Submitted by Konstantin Khorenko on Nov. 24, 2018, 3:12 p.m.

Details

Message ID 201811241512.wAOFCCvb030425@finist-ce7.sw.ru
State New
Series "ksm: Switch to xxhash hash algorithm"
Headers show

Commit Message

Konstantin Khorenko Nov. 24, 2018, 3:12 p.m.
The commit is pushed to "branch-rh7-3.10.0-862.20.2.vz7.73.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-862.20.2.vz7.73.8
------>
commit 5df8dc1eb691271b92562bcfc43b458f3996596a
Author: Timofey Titovets <nefelim4ag@gmail.com>
Date:   Sat Nov 24 18:12:12 2018 +0300

    ms/ksm: replace jhash2 with xxhash
    
    Replace jhash2 with xxhash.
    
    Perf numbers:
    Intel(R) Xeon(R) CPU E5-2420 v2 @ 2.20GHz
    ksm: crc32c   hash() 12081 MB/s
    ksm: xxh64    hash()  8770 MB/s
    ksm: xxh32    hash()  4529 MB/s
    ksm: jhash2   hash()  1569 MB/s
    
    Sioh Lee did some testing:
    
    crc32c_intel: 1084.10ns
    crc32c (no hardware acceleration): 7012.51ns
    xxhash32: 2227.75ns
    xxhash64: 1413.16ns
    jhash2: 5128.30ns
    
    As jhash2 always will be slower (for data size like PAGE_SIZE).  Don't use
    it in ksm at all.
    
    Use only xxhash for now, because for using crc32c, cryptoapi must be
    initialized first - that requires some tricky solution to work well in all
    situations.
    
    Link: http://lkml.kernel.org/r/20181023182554.23464-3-nefelim4ag@gmail.com
    Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
    Signed-off-by: leesioh <solee@os.korea.ac.kr>
    Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
    Reviewed-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
    Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
    
    =====================
    Patchset description:
    
    ksm: Switch to xxhash hash algorithm
    
    xxhash shows better performance in comparison to currently
    used jhash2:
    
            ksm: xxh64 hash() 8770 MB/s
            ksm: xxh32 hash() 4529 MB/s
            ksm: jhash2 hash() 1569 MB/s
    
    Note, that algorithm module lib/xxhash.c is already in ms kernel [1/3],
    while [2-3/3] just make ksm to use it (but they also already in akpm tree).
    
    This should improve ksm performance in some way.
    
    Nick Terrell (1):
          lib: Add xxhash module
    
    Timofey Titovets (2):
          xxHash: create arch dependent 32/64-bit xxhash()
          ksm: replace jhash2 with xxhash
    
    https://jira.sw.ru/browse/PSBM-90044
---
 mm/Kconfig | 1 +
 mm/ksm.c   | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/mm/Kconfig b/mm/Kconfig
index d22a5c8d75e2..f5c611b8a342 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -340,6 +340,7 @@  config MMU_NOTIFIER
 config KSM
 	bool "Enable KSM for page merging"
 	depends on MMU
+	select XXHASH
 	help
 	  Enable Kernel Samepage Merging: KSM periodically scans those areas
 	  of an application's address space that an app has advised may be
diff --git a/mm/ksm.c b/mm/ksm.c
index 53316ae8057c..1fb8051b22e4 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -23,7 +23,7 @@ 
 #include <linux/pagemap.h>
 #include <linux/rmap.h>
 #include <linux/spinlock.h>
-#include <linux/jhash.h>
+#include <linux/xxhash.h>
 #include <linux/delay.h>
 #include <linux/kthread.h>
 #include <linux/wait.h>
@@ -998,7 +998,7 @@  static u32 calc_checksum(struct page *page)
 {
 	u32 checksum;
 	void *addr = kmap_atomic(page);
-	checksum = jhash2(addr, PAGE_SIZE / 4, 17);
+	checksum = xxhash(addr, PAGE_SIZE, 0);
 	kunmap_atomic(addr);
 	return checksum;
 }