cr-exec: initialize the creds pointer to NULL

Submitted by Andrei Vagin on July 14, 2016, 5:57 a.m.

Details

Message ID 1468475846-3699-1-git-send-email-avagin@openvz.org
State Accepted
Series "cr-exec: initialize the creds pointer to NULL"
Commit 7534c2bf7a8b8b66e617e7f62a598dd485c986bf
Headers show

Commit Message

Andrei Vagin July 14, 2016, 5:57 a.m.
From: Andrew Vagin <avagin@virtuozzo.com>

Error (arch/x86/crtools.c:83): Failed to get auxval, err: 0
==2103== Conditional jump or move depends on uninitialised value(s)
==2103==    at 0x46F073: seize_wait_task (ptrace.c:238)
==2103==    by 0x437592: cr_exec (cr-exec.c:137)
==2103==    by 0x41F6FC: main (crtools.c:789)

Signed-off-by: Andrew Vagin <avagin@virtuozzo.com>
---
 criu/cr-exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/criu/cr-exec.c b/criu/cr-exec.c
index 26a8497..ba38269 100644
--- a/criu/cr-exec.c
+++ b/criu/cr-exec.c
@@ -119,7 +119,7 @@  int cr_exec(int pid, char **opt)
 	struct parasite_ctl *ctl;
 	struct vm_area_list vmas;
 	int ret, prev_state, exit_code = -1;
-	struct proc_status_creds *creds;
+	struct proc_status_creds *creds = NULL;
 
 	if (!sys_name) {
 		pr_err("Syscall name required\n");

Comments

Pavel Emelianov July 14, 2016, 11:19 a.m.
On 07/14/2016 09:12 AM, Patchwork wrote:
> == Series Details ==
> 
> Series: cr-exec: initialize the creds pointer to NULL
> URL   : https://patchwork.criu.org/series/350/
> State : failure
> 
> == Logs ==
> 
> For more details see: https://ci.openvz.org/job/CRIU/job/criu-patchwork/456//console

Patch doesn't apply :\ Should I wait for [PATCH v2] from you? ;)
Andrey Vagin July 15, 2016, 2:29 a.m.
On Thu, Jul 14, 2016 at 02:19:29PM +0300, Pavel Emelyanov wrote:
> On 07/14/2016 09:12 AM, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: cr-exec: initialize the creds pointer to NULL
> > URL   : https://patchwork.criu.org/series/350/
> > State : failure
> > 
> > == Logs ==
> > 
> > For more details see: https://ci.openvz.org/job/CRIU/job/criu-patchwork/456//console
> 
> Patch doesn't apply :\ Should I wait for [PATCH v2] from you? ;)
>

I resent it as a part of [PATCH 0/5 v2] test: check criu exec