build: Show a note when building wihout libbsd

Submitted by Radostin Stoyanov on Jan. 4, 2019, 6:30 p.m.

Details

Message ID 20190104183029.26036-1-rstoyanov1@gmail.com
State Accepted
Series "build: Show a note when building wihout libbsd"
Headers show

Commit Message

Radostin Stoyanov Jan. 4, 2019, 6:30 p.m.
Show a note that when libbsd is not installed CRIU is compiled without
setproctitle() and strlcpy() support.

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
---
 Makefile.config | 3 +++
 1 file changed, 3 insertions(+)

--
2.20.1

Patch hide | download patch | download mbox

diff --git a/Makefile.config b/Makefile.config
index 0e557805c..d89ccbb1a 100644
--- a/Makefile.config
+++ b/Makefile.config
@@ -5,6 +5,9 @@  include scripts/feature-tests.mak
 ifeq ($(call try-cc,$(FEATURE_TEST_LIBBSD_DEV),-lbsd),true)
         LIBS_FEATURES	+= -lbsd
         FEATURE_DEFINES	+= -DCONFIG_HAS_LIBBSD
+else
+        $(info Note: Building without setproctitle() and strlcpy() support.)
+        $(info $(info)      To enable these features, please install libbsd-devel (RPM) / libbsd-dev (DEB).)
 endif

 ifeq ($(call pkg-config-check,libselinux),y)

Comments

Andrei Vagin Jan. 9, 2019, 6:25 a.m.
Applied, thanks!

On Fri, Jan 04, 2019 at 06:30:29PM +0000, Radostin Stoyanov wrote:
> Show a note that when libbsd is not installed CRIU is compiled without
> setproctitle() and strlcpy() support.
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
> ---
>  Makefile.config | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile.config b/Makefile.config
> index 0e557805c..d89ccbb1a 100644
> --- a/Makefile.config
> +++ b/Makefile.config
> @@ -5,6 +5,9 @@ include scripts/feature-tests.mak
>  ifeq ($(call try-cc,$(FEATURE_TEST_LIBBSD_DEV),-lbsd),true)
>          LIBS_FEATURES	+= -lbsd
>          FEATURE_DEFINES	+= -DCONFIG_HAS_LIBBSD
> +else
> +        $(info Note: Building without setproctitle() and strlcpy() support.)
> +        $(info $(info)      To enable these features, please install libbsd-devel (RPM) / libbsd-dev (DEB).)
>  endif
> 
>  ifeq ($(call pkg-config-check,libselinux),y)
> --
> 2.20.1
> 
> _______________________________________________
> CRIU mailing list
> CRIU@openvz.org
> https://lists.openvz.org/mailman/listinfo/criu